SimpleSigner: change network to interface

[nkryuchkov]

Changes:

• SimpleSigner expects an interface type for the network parameter instead of core.Network

ssvlabs/ssv#1308 introduces support of custom network configs where any value can be overridden. Currently, SimpleSigner expects the network parameter of the type core.Network which means that it supports only values stored in this repository. On any other values, it returns default zero-values or crashes.

Therefore, when the SSV node calls NewSimpleSigner on setting up a KeyManager, if the network name differs from supported, then SimpleSigner would not work as expected.

The SimpleSigner uses two core.Network's methods:

• EstimatedEpochAtSlot(slot phase0.Slot) phase0.Epoch
• EstimatedSlotAtTime(time int64) phase0.Slot

EstimatedEpochAtSlot calls only SlotsPerEpoch which returns 32 for any network. However, EstimatedSlotAtTime calls MinGenesisTime which returns 0 for unknown ones.

The PR changes the type of the network parameter to the interface below to allow the SSV node to just pass any network matching the interface.

type network interface {
	EstimatedEpochAtSlot(slot phase0.Slot) phase0.Epoch
	EstimatedSlotAtTime(time int64) phase0.Slot
}

[iurii-ssv]

Minor suggestions

[y0sher]

@nkryuchkov @oleg-ssvlabs I have actually fixed a bug in this pr in this branch debug/simple-signer-network-interface we should probably pull them here.

[oleg-ssvlabs]

@nkryuchkov @oleg-ssvlabs I have actually fixed a bug in this pr in this branch debug/simple-signer-network-interface we should probably pull them here.

do you mean in62dfd67eb8841354eb63ea8f316c6e4e5fced013 commit ?

[nkryuchkov]

@nkryuchkov @oleg-ssvlabs I have actually fixed a bug in this pr in this branch debug/simple-signer-network-interface we should probably pull them here.

@y0sher What bug does it fix?

[moshe-blox]

lgtm 👌

[Copilot]

Pull Request Overview

This PR updates the SimpleSigner component to accept a more flexible network interface, allowing custom network configurations to be passed in instead of being restricted to the pre-defined core.Network.

• Changed the network parameter type in SimpleSigner and related functions from core.Network to a new Network interface.
• Updated time handling in network functions and tests by replacing Unix timestamps with time.Time values and using time.Add for time deltas.
• Updated tests in signer and core packages to accommodate the new Network interface and time representations.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
signer/validator_signer.go	Updated SimpleSigner to use the new Network interface with time.Time-based methods.
signer/sign_beacon_block_test.go	Updated time parameter usage for far future validation tests.
signer/sign_attestation_test.go	Updated time parameter usage in attestation tests.
signer/far_future_protection.go	Refactored far future protection to use time.Time and updated delta variable.
core/networks_test.go	Updated tests to use time.Time in slot estimation.
core/networks.go	Modified the EstimatedSlotAtTime method signature and logic to use time.Time instead of Unix timestamps.