fix: add owner validatation to resign#31
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses F-dkg-spec-003 by ensuring a Resign message’s Owner matches the Owner embedded in the accompanying ceremony SignedProof, aligning resign validation behavior with existing reshare validation.
Changes:
- Add an owner equality check between
resign.Ownerandproof.Proof.OwnerinValidateResignMessage. - Update resign validation tests to assert an error when the resign owner differs from the proof owner.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
resign.go |
Adds owner/proof owner mismatch validation to prevent accepting resign messages with unrelated proofs. |
testing/resign_test.go |
Updates the relevant test case to expect "invalid owner address" when the owner does not match the proof. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
momosh-ssv
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
F-dkg-spec-003