Internal/ptr uint64/replace cleanup - #759
Conversation
The terminal-unsafe version is still available as 'unsafe_replace(ptr, lvl)'
In general, the word 'label' is soon-to-be deprecated in <adiar/internal/...>
Until now, we have always assumed the identity order. That is, we have always assumed that 'label' = 'level'. This paves the way for variable reordering. The only thing that remains is 'max_label'; assuming the user are using variables 0, 1, ..., n this is reasonable since the 'ptr_uint64' representation bounds the size of 'n'.
52ef238 to
672eef0
Compare
🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.37% (stdev: 1.12%).
Number of samples: 10 |
🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.15% (stdev: 0.59%).
Number of samples: 10 |
🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.48% (stdev: 1.34%).
Number of samples: 10 |
🟡 Regression Test (12-Queens)'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.10% (stdev: 0.27%).
Number of samples: 10 |
🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.38% (stdev: 1.27%).
Number of samples: 10 |
🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.03% (stdev: 1.00%).
Number of samples: 10 |
🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.10% (stdev: 0.38%).
Number of samples: 10 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=============================================
- Coverage 97.039% 97.039% -0.000%
=============================================
Files 99 99
Lines 7296 7295 -1
=============================================
- Hits 7080 7079 -1
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.35% (stdev: 1.12%).
Number of samples: 10 |
🟡 Regression Test (Picotrav 'arbiter')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -1.96% (stdev: 28.53%).
Number of samples: 10 |
🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.41% (stdev: 0.91%).
Number of samples: 10 |
🟡 Regression Test (14-Queens)'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.28% (stdev: 0.39%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'mem_ctrl')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.42% (stdev: 0.60%).
Number of samples: 3 |
🟡 Regression Test (Picotrav 'adder')'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.11% (stdev: 0.80%).
Number of samples: 10 |
Various clean-up as a pre-cursor for #407, #500, and #730
__replacefunctions that liftreplace(ptr_uint64, int)to a map function to the respective data types. That is, make these actual "features" in<adiar/internal/...>.replacefunctionslabelandlabel_typefrom the internal data types. This is needed fordd_reorder(f,π): (Explicit) Variable (Re)Ordering #407 to not continue the confusing mixing of "labels" and "levels" due to assuming the identity order.