Skip to content

Internal/ptr uint64/replace cleanup - #759

Merged
ssoelvsten merged 8 commits into
mainfrom
internal/ptr_uint64/replace-cleanup
May 12, 2026
Merged

Internal/ptr uint64/replace cleanup#759
ssoelvsten merged 8 commits into
mainfrom
internal/ptr_uint64/replace-cleanup

Conversation

@ssoelvsten

@ssoelvsten ssoelvsten commented May 12, 2026

Copy link
Copy Markdown
Owner

Various clean-up as a pre-cursor for #407, #500, and #730

  • Move the __replace functions that lift replace(ptr_uint64, int) to a map function to the respective data types. That is, make these actual "features" in <adiar/internal/...>.
  • Clean-up in the current replace functions
  • Add comment headers for each sub-algorithm section. Maybe this is enough to make the file visually divided into sections. If not, then we'll have to split it into multiple files.
  • Removed label and label_type from the internal data types. This is needed for dd_reorder(f,π): (Explicit) Variable (Re)Ordering #407 to not continue the confusing mixing of "labels" and "levels" due to assuming the identity order.

@ssoelvsten ssoelvsten added this to the v2.2 : Variable Reordering milestone May 12, 2026
@ssoelvsten ssoelvsten self-assigned this May 12, 2026
@ssoelvsten ssoelvsten added ✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens labels May 12, 2026
Until now, we have always assumed the identity order. That is, we have
always assumed that 'label' = 'level'. This paves the way for variable
reordering.

The only thing that remains is 'max_label'; assuming the user are
using variables 0, 1, ..., n this is reasonable since the 'ptr_uint64'
representation bounds the size of 'n'.
@ssoelvsten
ssoelvsten force-pushed the internal/ptr_uint64/replace-cleanup branch from 52ef238 to 672eef0 Compare May 12, 2026 15:06
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'httt/4x4_9_tippy_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.37% (stdev: 1.12%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 8882.40 8915.40
Standard Deviation 58.79 100.21

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'breakthrough_dual/3x6_10_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.15% (stdev: 0.59%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 5344.20 5336.20
Standard Deviation 20.14 31.36

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'connect4/6x6_11_connect4_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.48% (stdev: 1.34%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 11629.30 11573.50
Standard Deviation 156.22 63.86

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (12-Queens)

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.10% (stdev: 0.27%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 9597.50 9588.30
Standard Deviation 22.57 26.36

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'breakthrough/3x4_19_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.38% (stdev: 1.27%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 20982.30 20901.70
Standard Deviation 266.09 62.35

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'ep/8x8_7_e-8-1_p-3-4_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.03% (stdev: 1.00%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 27699.30 27708.70
Standard Deviation 164.46 278.22

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'domineering/5x5_13_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.10% (stdev: 0.38%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 14469.30 14455.10
Standard Deviation 36.58 54.94

Number of samples: 10

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.039%. Comparing base (6c402e8) to head (672eef0).

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #759       +/-   ##
=============================================
- Coverage   97.039%   97.039%   -0.000%     
=============================================
  Files           99        99               
  Lines         7296      7295        -1     
=============================================
- Hits          7080      7079        -1     
  Misses         216       216               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'ep_dual/8x8_6_e-8-1_p-2-3_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.35% (stdev: 1.12%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 5057.40 5039.60
Standard Deviation 56.29 56.39

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (Picotrav 'arbiter')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -1.96% (stdev: 28.53%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 47045.60 47968.60
Standard Deviation 12454.09 13683.57

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (QBF 'hex/hein_08_5x5-11_bwnib')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.41% (stdev: 0.91%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 16881.00 16811.40
Standard Deviation 143.47 152.20

Number of samples: 10

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (14-Queens)

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of 0.28% (stdev: 0.39%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 258101.33 257368.67
Standard Deviation 1018.86 230.34

Number of samples: 3

@ssoelvsten
ssoelvsten merged commit 39b24c1 into main May 12, 2026
27 of 28 checks passed
@ssoelvsten
ssoelvsten deleted the internal/ptr_uint64/replace-cleanup branch May 12, 2026 16:36
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (Picotrav 'mem_ctrl')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.42% (stdev: 0.60%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 348756.00 350233.00
Standard Deviation 1131.90 2114.65

Number of samples: 3

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

🟡 Regression Test (Picotrav 'adder')

'ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup' is a change in performance of -0.11% (stdev: 0.80%).

... origin/main ssoelvsten/adiar/internal/ptr_uint64/replace-cleanup
Mean 11139.10 11151.50
Standard Deviation 88.57 51.51

Number of samples: 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ code quality Uncle Bob would be proud 📁 internal This is where the ✨magic✨happens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant