[TLE] Fix improve parsing of names in corner cases #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some corner cases that were not well handled with satellite names starting with '1', '1 ', '2', '2 ' in tle files that don't have the leading '0 ' on the 0-line. This PR fixes it and adds unit tests covering problematic existing TLEs.
Unfortunately when working with TLEs from multiple sources (SpaceTrack, Celestrac, McCants, Satnogs, self-crafted) they are not always identically formatted, with or without 0-line, with or without leading
0on the 0-line and even with or without 0-padding on shorter-than-5-digits sat numbers. Those are now all fixed and covered in unit test.This fix uses the same 'strategy'' to get the satellite name as done in cbassa/strf#63 which is now successfully used by a number of persons working on heterogeneous TLE data sets.
The added test set covering all identified problematic cases:
This fixes #7
PS: I'm new to Rust so i'd happily update / improve this PR as required.