[TM-joke] Add pony_xeno modular xenos with admin spawn support

[PhantornRU]

Summary

This PR adds a new modular pony_xeno pack that introduces four pony-themed hostile AI xenomorph castes built on top of the existing /mob/living/carbon/xenomorph ecosystem.

The module keeps pony enemies inside the current xeno lifecycle and infrastructure, including caste datums, hive flow, AI/pathfinding, combat loop, minimap, actions, death/remains, and modular sound hooks.

What Changed

• Added new modular pack wiring under modular/pony_xeno and included it from modular/modular.dme.
• Added base pony xeno implementation with naming, flavor, blood/gibs/remains, minimap helpers, and a local test spawner.
• Added runtime composite sprite generation with deterministic appearance data, part/palette driven assembly, caching, and runtime icon pack generation.
• Added four castes: Pegasus Skirmisher, Earth Bruiser, Unicorn Caster, and Alicorn Matriarch.
• Added pony-specific sounds, icons, effects, and naming assets.
• Added admin spawn integration through pony caste defines, RoleAuthority.get_caste_by_text(), Create Xenos, Game Master Panel, and GM ambush submenu parity.
• Refactored pony directional icon pack assembly to avoid runtime bad icon operation during Insert().

Runtime / Tech Notes

• Pony appearance generation now carries armor variant selection in the appearance datum and cache key.
• Generated directional icons are assembled as single-direction canvases before insertion into the multi-state pack.
• Render offsets are now more stable and data-driven through caste-level base offsets and direction-specific adjustments.

Verification

• git diff --check
• ./tools/build/build.bat --ci dm -DCIBUILDING -DANSICOLORS -Werror

Changelog

🆑
add: new modular pony_xeno hostile AI xeno pack with four pony-themed castes
add: runtime pony composite sprite generation from separate pony body parts with caching
add: pony-specific sounds, blood, gibs, remains, minimap visuals, naming, and local test spawner
add: pony caste support in Create Xenos, Game Master Panel, and GM ambush spawning
fix: pony runtime icon pack generation no longer throws bad icon operation on directional state assembly
refactor: pony render offsets and icon assembly path are now more stable and data-driven
/:cl:

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Code Review

This pull request introduces the pony_xeno module, adding four equine-themed xenomorph castes along with a data-driven runtime sprite composition system and admin spawn integration. Review feedback identifies a logic bug in client prefix assignment and suggests using the ALL_PONY_XENO_CASTES define in admin menus for better maintainability. Additionally, it was noted that sound metadata keys retain arachnid-specific naming, which should be refactored for clarity.

[gemini-code-assist]

There's a logic bug in this line. If client.xeno_prefix is null and client.xeno_postfix has a value, the expression (client.xeno_prefix || client.xeno_postfix) is true, but the ternary operator then returns client.xeno_prefix, which is null. This results in name_client_prefix being assigned the value "-", which is likely not intended. A more direct check would be clearer and avoid this bug.

		name_client_prefix = "[(client.xeno_prefix) ? client.xeno_prefix : "XX"]-"

[gemini-code-assist]

For better maintainability, you could append the ALL_PONY_XENO_CASTES list instead of listing each pony caste individually. This way, any new pony castes added to ALL_PONY_XENO_CASTES will be automatically included here.

#define GAME_MASTER_AI_XENOS (list(XENO_CASTE_DRONE, XENO_CASTE_WARRIOR_DRONE, XENO_CASTE_SOLDIER, XENO_CASTE_RUNNER, RUNNER_ACIDER, XENO_CASTE_LURKER, XENO_CASTE_CRUSHER, XENO_CASTE_DEFENDER, XENO_CASTE_SENTINEL, XENO_CASTE_SPITTER, XENO_CASTE_CARRIER, XENO_CASTE_PRAETORIAN, XENO_CASTE_RAVAGER, XENO_CASTE_PREDALIEN, XENO_CASTE_QUEEN, XENO_CASTE_KING, XENO_CASTE_FACEHUGGER, ARACHNID_CASTE_WARRIOR, ARACHNID_CASTE_BOMBARDIER) + ALL_PONY_XENO_CASTES) // SS220 EDIT - Arachnid, Pony xeno

[gemini-code-assist]

For better maintainability, you can use ALL_PONY_XENO_CASTES to append the new castes, similar to the pattern in other files. This ensures that the list stays up-to-date automatically if ALL_PONY_XENO_CASTES is ever modified.

#define GAME_MASTER_AMBUSH_AI_XENOS (list(XENO_CASTE_DRONE, XENO_CASTE_WARRIOR_DRONE, XENO_CASTE_SOLDIER, XENO_CASTE_RUNNER, XENO_CASTE_LURKER, XENO_CASTE_FACEHUGGER, XENO_CASTE_SENTINEL, XENO_CASTE_SPITTER, ARACHNID_CASTE_WARRIOR, ARACHNID_CASTE_BOMBARDIER) + ALL_PONY_XENO_CASTES) // SS220 EDIT - Arachnid, Pony xeno

[gemini-code-assist]

The keys used for sound metadata, such as ARACHNID_SOUND_META_PATH, appear to be inherited from the arachnid module. This is confusing in the context of the pony module. For better clarity and long-term maintainability, it would be beneficial to refactor these keys to be more generic (e.g., MODULAR_SOUND_META_PATH) if this sound system is intended for use across multiple modules. While changing this might be outside the scope of this PR, it's a valuable consideration for future improvements.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.