Skip to content

Rus main/esc menu - #108

Closed
Dimempers wants to merge 9 commits into
ss220-space:masterfrom
Dimempers:RusMenu
Closed

Rus main/esc menu#108
Dimempers wants to merge 9 commits into
ss220-space:masterfrom
Dimempers:RusMenu

Conversation

@Dimempers

@Dimempers Dimempers commented Jun 4, 2026

Copy link
Copy Markdown

Информация о PR

Переводит главное меню(лобби) + ескейп меню
Спрайты переведенных кнопок моего производства

Как это способствует улучшению игрового опыта на Немезиде?

Перевод

Доказательства тестирования

Изображения/Видео https://www.youtube.com/watch?v=Gu3a3dRsF7M

Список изменений

🆑
local: Меню лобби.
local: Escape меню.
/:cl:

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request localizes the escape menu interface into Russian. The review feedback highlights several areas for improvement: removing or translating temporary Russian comments in the code to comply with the style guide, correcting a typo in the suicide button label ('Суцидид' to 'Суицид'), improving the phrasing of the ghost button description, and fully localizing remaining English strings like 'Unset' and 'Pre-Game' in the details menu.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread code/modules/escape_menu/admin_page.dm Outdated
Comment thread code/modules/escape_menu/admin_page.dm Outdated
Comment thread code/modules/escape_menu/home_page.dm Outdated
Comment thread code/modules/escape_menu/home_page.dm Outdated
Comment thread code/modules/escape_menu/leave_body.dm Outdated
Comment thread code/modules/escape_menu/leave_body.dm Outdated
Comment thread code/modules/escape_menu/details.dm Outdated
@Dimempers

Copy link
Copy Markdown
Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request localizes the escape menu and lobby interface elements from English to Russian, including the integration of proper Russian declensions for player and admin counts. The review feedback points out several localization and code quality improvements: correcting an orthographic error ('Вернутся' to 'Вернуться'), fixing a grammatical gender mismatch ('Не начат' to 'Не начато' for 'время'), adopting more natural phrasing ('своё тело' instead of 'ваше тело'), hyphenating compound terms ('Баг-репорт' and 'админ-тикет'), and optimizing performance by caching the client count in a local variable to avoid multiple global list lookups.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread code/modules/escape_menu/leave_body.dm Outdated
Comment thread code/modules/escape_menu/details.dm Outdated
Comment thread code/modules/escape_menu/leave_body.dm Outdated
Comment thread code/_onclick/hud/screen_objects/new_player.dm Outdated
Comment thread code/modules/escape_menu/home_page.dm Outdated
Comment thread code/modules/escape_menu/admin_page.dm Outdated
@Ksaikok46

Copy link
Copy Markdown
Collaborator

@Dimempers

Copy link
Copy Markdown
Author

https://github.com/ss220-space/Nemesis/blob/master/modular_nemesis/README.md

Все будет, просто не сейчас

@github-actions

Copy link
Copy Markdown

Данный PR считается устаревшим, так как не обновлялся достаточно долгое время. Это означает, что он будет автоматически закрыт в течении 7 дней. Если это ошибка и PR в разработке, то сообщите об этом @Ревьювер в Discord.

@github-actions github-actions Bot added the Stale label Jun 20, 2026
@Dimempers

Copy link
Copy Markdown
Author

Не могу какое то время заниматся ПРом ибо уехал от компьютера, пока закрою

@Dimempers Dimempers closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants