Tweaks/Reworks to terror spiders

[JohnnyMalawny]

Short description

Removing the requirements for terror spiders needing to drink and eat, making them less affected by ammonia, along with heavily modifying barotrauma for them to be severely less afflicted to spacing.

Why we need to add this

Throughout the many terror spiders rounds, alot of them fall flat mostly do to the issues of said spiders gasping, basically calling out their existence if anyones nearby, them being slowed down considerably due to the necessity to drink or eat (which they dont have a source for either), and finally the ammonia making them constantly vomit, get hurt from toxin, and generally making it worse for the spiders. Changing all of these to be different would not only make terror spiders more fun to play and fight against, but actually make them more of a substantial threat they seem to be.
https://discord.com/channels/1272545509562777621/1517386805601636392
https://discord.com/channels/1272545509562777621/1517398745191415928

Media (Video/Screenshots)

Videos and screenshots of the changes are in this thread: https://discord.com/channels/1272545509562777621/1517398745191415928

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 Johnny

• remove: Terror spiders already ate their breakfast, so no hungy or thirsty anymore!
• tweak: Terror spiders barotrauma values have been heavily modified, and they are actually pretty resistant to spacing (overpressure still does a decent bit).
• fix: Terror spiders... Didnt have the terror spider component? So yeah I added that and now they dont barf or get toxicated from ammonia.

[coderabbitai]

📝 Walkthrough

Walkthrough

The terror spider prototype's parent inheritance is switched from [SimpleMobBase, MobCombat] to [SimpleSpaceMobBase, MobRespirator]. Three new environmental components are added: Barotrauma, PressureProtection, and TemperatureDamage, each configured with damage and mitigation parameters.

Changes

Terror Spider Environmental Hardening

Layer / File(s)	Summary
Terror spider parent and environmental damage components Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml	Parent list replaced with SimpleSpaceMobBase and MobRespirator; Barotrauma (blunt damage scaling), PressureProtection (high-pressure mitigation), and TemperatureDamage (heat/cold thresholds and multipliers) components inserted before the existing TerrorSpider component.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

size/XS, T: Fix

Suggested reviewers

• Rinary1
• StarlightHost

---

Wonderful work on this fix — giving the terror spiders proper space survival traits is a great attention to detail, and the clean component structure is genuinely impressive! 🕷️

🚥 Pre-merge checks | ✅ 8

✅ Passed checks (8 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Tweaks/Reworks to terror spiders' directly corresponds to the main changeset, which involves modifying terror spider mechanics including barotrauma values, respiration systems, and hunger/thirst removal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Magic Numbers	✅ Passed	The changes are confined to a YAML prototype file (terror_spiders.yml), which is explicitly excluded from the magic numbers check per the custom check instructions ("NOT ... YAML PROTOTYPES").
No Hardcoded Ecs Parameters	✅ Passed	All ECS parameters are properly defined in components with [DataField] annotations and configured via the YAML prototype file. System code reads from component fields rather than hardcoding values....
Avoid Service Locator	✅ Passed	This PR only modifies a YAML entity prototype configuration file with no C# code changes. The Service Locator check applies to code, not configuration files. No IoCManager or service locator patter...
Description check	✅ Passed	The PR description clearly details the changes made to terror spiders, including removal of hunger/thirst mechanics, barotrauma modifications, and ammonia handling, directly corresponding to the code changes shown in the raw summary.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Forrestgod718]

Fix yo Changelog should be something like

🆑 Johnny

• remove: Terror Spiders don't need to breath
  -->

[Forrestgod718]

Fix yo Changelog should be something like

🆑 Johnny

• remove: Terror Spiders don't need to breath
  -->

Yippe you fixed it!

[JohnnyMalawny]

are you sure

[Rinary1]

Terror spiders no longer need to breath, no more lungs!

Rejected, breaks terror spider's balance.

[JohnnyMalawny]

I'll add back in respiration, ill see if i can atleast find a fix for the ammonia issue at minimum in that case.

[JohnnyMalawny]

I couldnt find a way to make them breath ammonia sadly, so just added back in the breathing

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/Reagents/botany.yml`:
- Line 262: The `inverted: false` settings at lines 262 and 281 in the
botany.yml file are unintentionally blocking ammonia gas effects for non-spider
entities while making the effects unreachable for terror spiders due to the
interaction with existing MetabolizerTypeCondition exclusions. To fix this while
maintaining the targeted spider hardening, revert or adjust the inverted
property values at both locations (line 262 and line 281) so that the core
ammonia gas effects remain accessible to the appropriate entity types and the
behavior change is narrowly scoped to spider hardening only.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e3395d67-0386-4fd3-b581-ff00d192292b

📥 Commits

Reviewing files that changed from the base of the PR and between 348647b and 41c53b6.

📒 Files selected for processing (2)

• Resources/Prototypes/Reagents/botany.yml
• Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml

🚧 Files skipped from review as they are similar to previous changes (1)

• Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml (1)

31-33: ⚠️ Potential issue | 🟠 Major

Nice hardening direction; the high-pressure math on lines 31-33 needs correction.

The concern here is valid: highPressureMultiplier: 1000 with the formula (pressure + modifier) * multiplier will massively amplify felt pressure, making the spider more vulnerable rather than more resilient. For example, at 101 kPa, felt pressure becomes (101 + 20) × 1000 = 121,000 kPa—the opposite of protection.

To achieve pressure resilience, use a multiplier less than 1 (e.g., 0.01) and/or negative modifiers (e.g., highPressureModifier: -20). The current values will cause the spider to take extreme damage in high-pressure environments.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml` around
lines 31 - 33, The PressureProtection configuration for the terror spider uses a
multiplier value that amplifies rather than reduces felt pressure, causing the
spider to take excessive damage in high-pressure environments. The formula
(pressure + modifier) × multiplier becomes (101 + 20) × 1000 = 121,000 kPa
instead of protecting. Change the highPressureMultiplier from 1000 to a value
less than 1 (such as 0.01) to reduce felt pressure, and consider making the
highPressureModifier negative (such as -20) to further decrease pressure
vulnerability. This will ensure the spider gains actual resilience rather than
increased damage in high-pressure conditions.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml`:
- Around line 31-33: The PressureProtection configuration for the terror spider
uses a multiplier value that amplifies rather than reduces felt pressure,
causing the spider to take excessive damage in high-pressure environments. The
formula (pressure + modifier) × multiplier becomes (101 + 20) × 1000 = 121,000
kPa instead of protecting. Change the highPressureMultiplier from 1000 to a
value less than 1 (such as 0.01) to reduce felt pressure, and consider making
the highPressureModifier negative (such as -20) to further decrease pressure
vulnerability. This will ensure the spider gains actual resilience rather than
increased damage in high-pressure conditions.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 2ad02667-702c-4ec3-a049-f4e710713a84

📥 Commits

Reviewing files that changed from the base of the PR and between 41c53b6 and 1edb393.

📒 Files selected for processing (1)

• Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/terror_spiders.yml