Skip to content

A new Mentor Help Tip!#4845

Closed
Forrestgod718 wants to merge 5 commits into
ss14Starlight:starlight-devfrom
Forrestgod718:mhelp-tips
Closed

A new Mentor Help Tip!#4845
Forrestgod718 wants to merge 5 commits into
ss14Starlight:starlight-devfrom
Forrestgod718:mhelp-tips

Conversation

@Forrestgod718

Copy link
Copy Markdown
Contributor

Short description

Just adds a single new tip, It mentions to any new players (if the tip appears) About the mentor help system! I had to place it in a non _Starlight folder because the tips command is set by a CVAR to follow this specific file, So I at the very least added a comment stating its an _Starlight Change

Why we need to add this

Tess has been recently trying to help with making the mentor help system more known, Doing this should help with that.

Media (Video/Screenshots)

image

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Forrestgod
- add: Added a new mentor Help System Tip!

@Forrestgod718 Forrestgod718 requested a review from a team June 18, 2026 12:24
@github-actions github-actions Bot added Changes: No C# Changes: Prototypes size/XS S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e0b7ab8f-0599-42f8-89d8-f83184039367

📥 Commits

Reviewing files that changed from the base of the PR and between 896af8a and d48821a.

📒 Files selected for processing (2)
  • Resources/Locale/en-US/tips.ftl
  • Resources/Prototypes/Datasets/tips.yml

📝 Walkthrough

Walkthrough

Adds a new tip entry (tips-dataset-140) to the English US localization file directing players to use the mhelp system to contact mentors, and increments the Tips dataset count from 139 to 140 in the YAML prototype.

Changes

New mhelp tip entry

Layer / File(s) Summary
Tip text and dataset count update
Resources/Locale/en-US/tips.ftl, Resources/Prototypes/Datasets/tips.yml
Adds the tips-dataset-140 localization key with mhelp mentor guidance text (tagged _Starlight) and increments the Tips dataset count from 139 to 140.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


What a clean, precise little contribution — perfectly paired files updated in lockstep! 🎉 The localization key and the dataset count are both exactly right. Great work keeping things tidy!

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: adding a new mentor help tip to the system.
Description check ✅ Passed The description is well-structured and directly related to the changeset, providing context, rationale, and supporting documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Magic Numbers ✅ Passed The PR adds a localization entry and updates a YAML prototype count. YAML prototypes are explicitly excluded from this check. The numeric identifier in tips.ftl is just an index key, not a magic nu...
No Hardcoded Ecs Parameters ✅ Passed PR only adds tip text and dataset count; no ECS system logic or hardcoded parameters introduced. Changes are purely configuration data without violating the ECS parameter check.
Avoid Service Locator ✅ Passed This PR only modifies data files (tips.ftl localization and tips.yml configuration), adding a tip string and updating a count. No code, service locators, or IoC patterns are introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Forrestgod718

Copy link
Copy Markdown
Contributor Author

Already fixed my Grammer mistake with the capital B btw

@Forrestgod718

Copy link
Copy Markdown
Contributor Author

Alright well uh..following the guidance of crazyphantom imma close this PR and open another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants