New Shuttle: NTS 'Kickstart' Ingeniator#4749
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.IntegrationTests/Tests/_Starlight/Power/GridPowerTests.cs`:
- Around line 96-98: The GridPaths array has missing commas between consecutive
entries (the new("/Maps/_Starlight/Shuttles/emergency_lox.yml"),
new("/Maps/_Starlight/Shuttles/emergency_Ingeniator.yml"),
new("/Maps/_Starlight/Shuttles/Ingeniator.yml") lines), which breaks
compilation; add commas to separate each entry in the GridPaths initializer so
each new(...) is a distinct element (e.g. insert a comma after each new(...)
except the last) and ensure the GridPaths collection compiles correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: cd97b32c-4077-442a-a1ac-fd23357f0830
📒 Files selected for processing (3)
Content.IntegrationTests/Tests/_Starlight/Power/GridPowerTests.csResources/Maps/Shuttles/Ingeniator.ymlResources/Maps/Shuttles/emergency_Ingeniator.yml
Based on coderabbitai's suggestion
|
You could shrink this shuttle considerably by going for the small reactor and turbine. Despite their smaller footprint they're still MORE than capable of powering a full station. I also find it quite interesting that there's no room for a tesla/singulo based engine. |
|
Noted, I will swap them out and see what I can do with them. |
CawsForConcern
left a comment
There was a problem hiding this comment.
review
invalid YML
your SMES start with settings that leave them unable to provide power to the rest of the shuttle, despite having plenty of power stored.
reviewing the map YML, your shuttle's SMES looks like this
- proto: SMESAdvanced
entities:
- uid: 462
components:
- type: Transform
pos: -8.5,33.5
parent: 1
- type: Battery
lastCharge: 15998939
- type: PowerNetworkBattery
loadingNetworkDemand: 31830.031
currentSupply: 31830.031
supplyRampPosition: 31830.031
- type: DeviceNetwork
address: SMS-4D47-989D
transmitFrequency: 1621
receiveFrequency: 1621
- type: ContainerContainer
containers:
machine_board: !type:Container
showEnts: False
occludes: True
ents:
- 463
machine_parts: !type:Container
showEnts: False
occludes: True
ents:
- 475
- 465
- 467
- 469
- 471
- 473
- type: BatterySelfRecharger
nextAutoRecharge: null
autoRechargeRate: 16000000for a normal shuttle, it looks like this:
- proto: SMESAdvanced
entities:
- uid: 260
components:
- type: Transform
pos: 8.5,-4.5
parent: 1this is the kind of stuff that happens when you save a live map / grid. it serializes a lot of junk that shouldn't be saved to the shuttle.
i would recommend that you remake this map entirely - it's got a lot of bad YML data in it to the point you would need to delete mostly every entity on the map and replace it.
your SL Vending Machine has a bunch of contraband in it somehow
i don't even know how this happened but the YML says that the 'engi dispenser' SLVendingMachienEngi has every single changeling, Syndicate uplink, and wizard ability in the game.
seriously it's like thousands of lines of YML entries, here's just a brief snippet
- proto: SLVendingMachineEngi
entities:
- uid: 2347
components:
- type: Transform
pos: -1.5,33.5
parent: 1
- type: Store
startingMap: invalid
fullListingsCatalog:
- id: EvolutionMenuAmalgamOverdose
destockTime: 0
name: evolutionmenu-utility-hyper-stims-name
discountCategory: null
description: evolutionmenu-utility-hyper-stims-desc
categories:
- ChangelingAbilityUtility
originalCost:
EvolutionPoint: 5
conditions:
- !type:ListingLimitedStockCondition
stock: 1
icon:
sprite: _Starlight/Actions/changeling.rsi
state: amalgam_overdose
priority: 0
productEntity: null
productAction: ActionAmalgamOverdose
productLanguage: null
productUpgradeId: null
productActionEntity: null
productEvent: null
raiseProductEventOnUser: False
purchaseAmount: 0
restockTime: 0
discountDownTo: {}
disableRefund: False
unavailable: False
applyToMob: False
costModifiersBySourceId: {}
- id: UplinkZombieBundle
destockTime: 0
name: uplink-zombie-bundle-name
discountCategory: null
description: uplink-zombie-bundle-desc
categories:
- UplinkChemicals
originalCost:
Telecrystal: 40
conditions:
- !type:StoreWhitelistCondition
blacklist: null
whitelist:
requireAll: False
tags:
- NukeOpsUplink
sizes: null
components: null
- !type:BuyerWhitelistCondition
blacklist:
requireAll: False
tags: null
sizes: null
components:
- SurplusBundle
whitelist: null
icon:
sprite: /Textures/Structures/Wallmounts/signs.rsi
state: bio
priority: 0
productEntity: ClothingBackpackDuffelZombieBundle
productAction: null
productLanguage: null
productUpgradeId: null
productActionEntity: null
productEvent: null
raiseProductEventOnUser: False
purchaseAmount: 0
restockTime: 0
discountDownTo: {}
disableRefund: False
unavailable: False
applyToMob: False
costModifiersBySourceId: {}it goes on like that for a long time
bridge could be more bridge-y
this is pretty plain. it could use some tables, cell rechargers, and most importantly - chairs. where are people going to sit when this thing FTLs?
don't map Command jobs to a shuttle
you've mapped the CE's locker, dresser, and suit storage to this shuttle. this introduces duplicate items into the round (stuff like the CE's custom suit, advanced magboots, etc) when it really shouldn't
decor
throw in some decals in here, a carpet, some chairs. where do people sit? where do people recharge their translators? where do people get some water for a drink? take a look at station maps for inspiration on how to fill out this room some more.
label your fax machines
you didn't name this fax machine, it'll show up as 'Unknown' on the fax list which isn't helpful for anyone. use a screwdriver on a fax machine to name it.
also, limit the amount of fax machines you have on a shuttle to 1.
put the AME parts the correct way around
your AME has all of its bits the wrong way around.
it should look like this
nuclear reactor is unanchored
it should be anchored
gas turbine is unanchored
it should be anchored
waste is broken
a bunch of your waste pipes aren't connected
loose light tube in burn chamber
use large thrusters if your shuttle is large
use the big thruster rather than lots of tiny ones. they're stronger. this shuttle is very large and should use large thrusters.
airlock locking logic on south side is weak
if you open both of the red airlocks and close only one of them, the south door will unbolt. this will space one of the two rooms
station maps
StationMap works on shuttles and you shuttle is large. you might as well throw a few of these around on the shuttle since you already have station beacons on it
grills under windows
generally grilles are put under all windows unless there's a very specific aesthetic choice being made
|
i would recommend making a "version 2" from scratch and taking the feedback into account. the YML stuff already involves deleting most entities and replacing them one thing I was impressed by was the airlock docking logic gates - I thought the airlocks would 'jam up' when docking to stations and i was pleasantly surprised they worked perfectly. really cool and very compact - it is genuinely a design I will look at implementing on more shuttles in the future. |
Update the Shuttles based on CawsForConcern's Feedback
|
The GitHub page has been updated with a new image. |
Add a nickname 'Kickstart' to the Grid's name.
Replace several small thrusters with large thrusters
Add a new Gyroscope
CawsForConcern
left a comment
There was a problem hiding this comment.
i think this is in a good enough state
approved!
redmushie
left a comment
There was a problem hiding this comment.
Aw man, EditorCheck fail real.
|
I fixed the issues that the EditorCheck complains. Hopefully, the rest of the tests are fine. |
b031216
Short description
Adding a new engineering shuttle, NTS 'Kickstart' Ingeniator. The Ingeniator is now a purchasable option in the shipyard console for 100,000 spesos.
Why we need to add this
This shuttle is designed as a recovery option for stations that have lost their entire Engineering department and are not yet ready to evacuate (or the captain thinks early EVAC is a cowardly move). Unlike the existing ERT Engineering Shuttle, it does not require crew or ERT personnel to assemble a new power generation system from scratch. Once docked, the shuttle's onboard atmospherics and power generation systems can immediately support the station, effectively serving as a mobile replacement for the station's engineering department and helping restore normal operations.
Media (Video/Screenshots)
Checks
Support I might need
Please, may I have an assistant to ensure the shuttle meets the requirements for Shuttle Request calls? It's my first time uploading a shuttle to the Starlight Project.
Bonus Points if the shuttle meets the minimum requirements for a valid Engineering Department under the Station's Guidelines.
Changelog
🆑 Hot_Mic