[Mapping] Required entities expansion

[CawsForConcern]

Short description

Adds a lot of entities to [ ShouldMap ].

Lockers:

• Job Lockers where it is unambiguous which should be mapped, e.g. we always prefer mapping the Heads' Locker separately from the Heads' Suit Storage
• Job Lockers that sometimes may use the [ Hardsuit ] variants (like Salvage, Engineering, Mining) are not required entities. The test isn't that fine.

Drobes:

• JobDrobe machines where the job is present on all maps.
• e.g. JaniDrobes should always be mapped, but sometimes CuraDrobes (for Librarians) aren't because there's no Librarian on Leth, Lobster, etc.

Computers:

• Computers that are required for gameplay (ID Computer, Comms Console, AI Restoration, AI Upload, etc.)
• Cargo shuttle computer
• Mining shuttle computer
• Salvage shuttle computer
• Also includes the [Mapping] Departmental Announcement Consoles #3780 as required entities.

Servers:

• RnD Server
• Crew monitoring Server
• All of the proper telecom servers.
• All of the camera servers.

Vending Machines:

• All of the Starlight vending machines (Engivend, Secvend, Medivend, Fashion-o-Mat, etc.)
• All of the job-required vending machines (e.g. Mining and Salvage Ticket Machines)

Misc Requirements:

• Ovens, Stoves
• SpawnpointLatejoin
• Salvage magnets
• Mail teleporter
• Contraband storage box
• Implanter crate (the one with 4 trackers and 4 mindshields)
• Golden toolbox and Vault freezer

i'll make an exhaustive list later when it's more finalized.

Why we need to add this

Mappers are forgetful (source: myself). Required entities help catch silly mistakes. I have no doubt that this is going to reveal dozens upon dozens of issues in existing maps.

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

[CawsForConcern]

marking as DONOTMERGE because this will break tests until maps are updated, but I want the tests to be able to run on this PR

will remove DONOTMERGE when maps are caught up (and also pending feedback if entities here should not be in the [ ShouldMap ] list!)

[coderabbitai]

Ready to act? Review this PR in Change Stack to turn feedback into patch suggestions you can inspect and refine.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Expanded the ShouldMapWhitelist in Content.IntegrationTests/Tests/PostMapInitTest.cs to include three Starlight station map YAML files and updated the Boxcars.yml entry comment.

Changes

Integration Tests — PostMapInitTest

Layer / File(s)	Summary
Whitelist expansion Content.IntegrationTests/Tests/PostMapInitTest.cs	Added StationBuilding.yml, Reach.yml, and Cork.yml to ShouldMapWhitelist and updated the Boxcars.yml whitelist entry/comment.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• ss14Starlight/space-station-14#4060 — Edits the same spawn-point prototypes (e.g., SpawnPointLatejoin); may overlap on prototype definitions.
• ss14Starlight/space-station-14#4337 — Modifies station maps Reach.yml and Cork.yml and related prototypes; potentially related.

Suggested reviewers

• Rinary1
• Conflee
• StarlightHost

Nice, tidy metadata additions — thanks!

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
No Magic Numbers	⚠️ Warning	PostMapInitTest.cs contains magic number 7 at line 328 in version >= 7 without extracting it into a named constant for the map format threshold.	Extract the value 7 into a named constant (e.g., const int MinimumMapFormatVersion = 7) and use it in the version comparison instead of the hardcoded literal.

✅ Passed checks (7 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[Mapping] Required entities expansion' directly summarizes the main change: adding many entities to the ShouldMapStation category for required mapping.
Description check	✅ Passed	The description clearly relates to the changeset, detailing which entity categories are being added to [ ShouldMap ], the rationale (catching mapper mistakes), and acknowledging that this will help improve map quality across the project.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Hardcoded Ecs Parameters	✅ Passed	All ~60 modified files are entity YAML prototypes adding categories: [ShouldMapStation] metadata fields. Categories are data-driven, loaded from YAML configs, not hardcoded in system logic.
Avoid Service Locator	✅ Passed	PR avoids service locator pattern. C# changes only add map paths to static whitelist. All ResolveDependency calls use proper injection (server parameter), not IoCManager antipatterns.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@Resources/Prototypes/_Starlight/Entities/Structures/Machines/Computers/computers.yml`:
- Line 212: The station maps Hotel, Leth, Prism, Reach, Saltern and
StationBuilding are missing the required ShouldMapStation prototypes
(ComputerCommsEngineering, ComputerCommsMedical, ComputerCommsScience,
ComputerCommsSecurity, ComputerCommsService, ComputerCommsCargo,
ComputerCommsLaw) which will fail the PostMapInitTest; fix by either re-saving
each affected map in the editor so the prototypes are added to their map
metadata (ensuring categories: [ ShouldMapStation ] includes those prototype
instances) or, if the omission is intentional, add the map identifiers to the
PostMapInitTest whitelist so they are exempt from enforcement.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 68d33786-c9bf-4463-8cf8-1878c941d3de

📥 Commits

Reviewing files that changed from the base of the PR and between f72bfa4 and 02b0d5c.

📒 Files selected for processing (49)

• Resources/Prototypes/Catalog/Fills/Crates/security.yml
• Resources/Prototypes/Catalog/Fills/Items/toolboxes.yml
• Resources/Prototypes/Catalog/Fills/Lockers/heads.yml
• Resources/Prototypes/Catalog/Fills/Lockers/medical.yml
• Resources/Prototypes/Catalog/Fills/Lockers/science.yml
• Resources/Prototypes/Catalog/Fills/Lockers/security.yml
• Resources/Prototypes/Catalog/Fills/Lockers/service.yml
• Resources/Prototypes/Catalog/Fills/Lockers/suit_storage.yml
• Resources/Prototypes/Entities/Markers/Spawners/jobs.yml
• Resources/Prototypes/Entities/Markers/Spawners/rooms.yml
• Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml
• Resources/Prototypes/Entities/Structures/Furniture/toilet.yml
• Resources/Prototypes/Entities/Structures/Machines/Computers/computers.yml
• Resources/Prototypes/Entities/Structures/Machines/crew_monitor_server.yml
• Resources/Prototypes/Entities/Structures/Machines/fax_machine.yml
• Resources/Prototypes/Entities/Structures/Machines/gravity_generator.yml
• Resources/Prototypes/Entities/Structures/Machines/grill.yml
• Resources/Prototypes/Entities/Structures/Machines/lathe.yml
• Resources/Prototypes/Entities/Structures/Machines/mail_teleporter.yml
• Resources/Prototypes/Entities/Structures/Machines/nuke.yml
• Resources/Prototypes/Entities/Structures/Machines/research.yml
• Resources/Prototypes/Entities/Structures/Machines/salvage.yml
• Resources/Prototypes/Entities/Structures/Machines/seed_extractor.yml
• Resources/Prototypes/Entities/Structures/Machines/surveillance_camera_routers.yml
• Resources/Prototypes/Entities/Structures/Machines/telecomms.yml
• Resources/Prototypes/Entities/Structures/Machines/vending_machines.yml
• Resources/Prototypes/Entities/Structures/Piping/Atmospherics/miners.yml
• Resources/Prototypes/Entities/Structures/Piping/Atmospherics/portable.yml
• Resources/Prototypes/Entities/Structures/Piping/Atmospherics/unary.yml
• Resources/Prototypes/Entities/Structures/Shuttles/station_anchor.yml
• Resources/Prototypes/Entities/Structures/Storage/Closets/Lockers/lockers.yml
• Resources/Prototypes/Entities/Structures/Storage/Crates/crates.yml
• Resources/Prototypes/Entities/Structures/Storage/glass_box.yml
• Resources/Prototypes/Entities/Structures/Storage/morgue.yml
• Resources/Prototypes/Entities/Structures/Wallmounts/Storage/wall_dispensers.yml
• Resources/Prototypes/Entities/Structures/Wallmounts/turret_controls.yml
• Resources/Prototypes/Entities/Structures/cryogenic_sleep_unit.yml
• Resources/Prototypes/Entities/Structures/meat_spike.yml
• Resources/Prototypes/_Funkystation/Entities/Structures/Machines/electrolyzer.yml
• Resources/Prototypes/_Starlight/Catalog/Fills/Crates/science.yml
• Resources/Prototypes/_Starlight/Catalog/Fills/Lockers/cargo.yml
• Resources/Prototypes/_Starlight/Catalog/Fills/Lockers/representatives.yml
• Resources/Prototypes/_Starlight/Entities/Objects/Tools/energydome.yml
• Resources/Prototypes/_Starlight/Entities/Structures/Machines/Computers/computers.yml
• Resources/Prototypes/_Starlight/Entities/Structures/Machines/Computers/nctterminal.yml
• Resources/Prototypes/_Starlight/Entities/Structures/Machines/oven.yml
• Resources/Prototypes/_Starlight/Entities/Structures/Machines/stove.yml
• Resources/Prototypes/_Starlight/Entities/Structures/Machines/telecomms.yml
• Resources/Prototypes/_Starlight/Entities/Structures/Machines/vending_machines.yml

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

required_ids=(
  CompuerShuttleSalvage
  ComputerShuttleMining
  ComputerCommsEngineering
  ComputerCommsMedical
  ComputerCommsScience
  ComputerCommsSecurity
  ComputerCommsService
  ComputerCommsCargo
  ComputerCommsLaw
)

map_files="$(fd -t f -e yml . Resources/Maps | rg '/Stations/')"

if [ -z "$map_files" ]; then
  echo "No station map YAML files found under Resources/Maps/**/Stations/."
  exit 1
fi

status=0
for id in "${required_ids[@]}"; do
  missing=0
  while IFS= read -r map; do
    if ! rg -n --fixed-strings "proto: ${id}" "$map" >/dev/null; then
      echo "MISSING: ${id} in ${map}"
      missing=1
      status=1
    fi
  done <<< "$map_files"

  if [ "$missing" -eq 0 ]; then
    echo "OK: ${id} present in all scanned station maps"
  fi
done

echo
echo "If any map is intentionally exempt, confirm it is in the station-map whitelist used by PostMapInitTest."
exit "$status"

Repository: ss14Starlight/space-station-14

Length of output: 3649

---

Add missing ShouldMapStation prototypes to station maps before merge.

Eight prototypes (ComputerCommsEngineering, ComputerCommsMedical, ComputerCommsScience, ComputerCommsSecurity, ComputerCommsService, ComputerCommsCargo, ComputerCommsLaw) are missing from six station maps (Hotel, Leth, Prism, Reach, Saltern, StationBuilding). ShouldMapStation enforcement is strict and will fail integration tests. Either re-save affected maps through the editor to include the new prototypes, or confirm the maps are intentionally exempt in the PostMapInitTest whitelist.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@Resources/Prototypes/_Starlight/Entities/Structures/Machines/Computers/computers.yml`
at line 212, The station maps Hotel, Leth, Prism, Reach, Saltern and
StationBuilding are missing the required ShouldMapStation prototypes
(ComputerCommsEngineering, ComputerCommsMedical, ComputerCommsScience,
ComputerCommsSecurity, ComputerCommsService, ComputerCommsCargo,
ComputerCommsLaw) which will fail the PostMapInitTest; fix by either re-saving
each affected map in the editor so the prototypes are added to their map
metadata (ensuring categories: [ ShouldMapStation ] includes those prototype
instances) or, if the omission is intentional, add the map identifiers to the
PostMapInitTest whitelist so they are exempt from enforcement.

[Rinary1]

Should be merged only after tests fixes.

[CawsForConcern]

New lockers added in #4540 to be considered, might leave them off as non-required for the immediate moment just so we can finally catch up to what is required

[CawsForConcern]

Thanks to Lex's herculean efforts in #4503 this test might actually pass now. Passed on local, going to double check here.

[CawsForConcern]

Thanks to Lex's herculean efforts in #4503 this test might actually pass now. Passed on local, going to double check here.

i'm dumb and ran the test on the wrong branch

edit: yeah this still needs more time to be fully implemented

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.