Replace futures with futures-util with no default features - #522
Open
paolobarbolini wants to merge 1 commit into
Open
Replace futures with futures-util with no default features#522paolobarbolini wants to merge 1 commit into
futures with futures-util with no default features#522paolobarbolini wants to merge 1 commit into
Conversation
paolobarbolini
had a problem deploying
to
test-environment
December 5, 2025 07:02 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces
futureswithfutures-util.futuresre-exports thefutures-utilAPI plus adds a few more things that this crate never uses, so making the switch reduces the dependency tree.I've also replaced two occurrences of
futures::executor::block_on(tokio::fs::remove_file(path)).unwrap();intest-toolswith std APIs, which didn't make sense because tokio expects it's own method to be called from it's own runtime. Alsotokio::fs::remove_filespawnsstd::fs::remove_fileon a blocking thread, so we may as well call the std API directly with no indirection.