Install server #60
Open
Install server #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyskens
suggested changes
Aug 15, 2019
Contributor
meyskens
left a comment
meyskens
left a comment
There was a problem hiding this comment.
Sorry for the delay!
Nice work! But we need a few things added to it before we can merge this
Author
|
@meyskens Thank you for the full review, I will apply changes soon. |
Three main things are reworked in that patch. Firstly, the update of the hostname and IP are moved in the Update handler. Then the apply changes is computed by terraform core, so it is useless to perform the check with `updateServerIfNeeded`. Finally, the init of the Server struct from the Server endpoint is also removed. Signed-off-by: Nicolas Gelot <[email protected]>
This patch adds the ability to create a server with the given settings. Signed-off-by: Nicolas Gelot <[email protected]>
Signed-off-by: Nicolas Gelot <[email protected]>
Signed-off-by: Nicolas Gelot <[email protected]>
Signed-off-by: Nicolas Gelot <[email protected]>
nfk
force-pushed
the
nfk/server_install
branch
from
cc66484 to
ea3c8b7
Compare
Signed-off-by: Nicolas Gelot <[email protected]>
Signed-off-by: Nicolas Gelot <[email protected]>
Signed-off-by: Nicolas Gelot <[email protected]>
nfk
force-pushed
the
nfk/server_install
branch
from
ea3c8b7 to
7aebd9e
Compare
Author
|
Hi @meyskens, backward compat looks good. In that updated MR I have added 2 data resources OS and SSH. I ran acceptance tests on my own server, then the documented example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously with the server resource we can only update the domain and edit the public IP. This PR adds the ability to create the server.