Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: improve build speed and image size #7767

Closed

Conversation

FrancoisCapon
Copy link
Contributor

@FrancoisCapon FrancoisCapon commented Dec 3, 2024

Hello,

Thanks for your feedback on my previous PR on Dockerfile.

Here's another one :

  • that uses uv to speed up "pip installs" (total gain of ~30%)
@home
docker system prune -f && build with no cache:
[+] Building 33.1s (22/22) FINISHED 
[+] Building 51.6s (15/15) FINISHED

@github action
#7767 Build Docker image 40s
#7675 Build Docker image 57s
  • that go below the 150MB size for the image
Total Image size: 149 MB         
Potential wasted space: 0 B
Image efficiency score: 100 % 

Perhaps, you know the documentation framework used 😉
https://docs.astral.sh/uv/

By the way, no feedback on my idea of setting palettes for pages and sections?

@squidfunk
Copy link
Owner

Thanks for the PR. However, we're not considering merging this right now. The reason is that we currently do not want to introduce any new dependencies, because we're working from first principles in the background, hence we have a feature freeze. I understand this is an optimization, but it bears the risk of more maintenance down the road.

I hope for your understanding. Thanks!

@squidfunk squidfunk closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants