Fix file save regression in privacy plugin #7673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nejch
commented
Nov 5, 2024
| @@ -467,7 +467,7 @@ def _patch(self, initiator: File): | |||
|
|
|||
| # Replace callback | |||
| def replace(match: Match): | |||
| value = match.group(1) | |||
| value = match.group("url") | |||
There was a problem hiding this comment.
It seems the issue was that replace was called on the self.assets_expr_map[extension] entry in the parent method, which we've changed so positional groups didn't always give reliable results.
There was a problem hiding this comment.
Perfect, thanks for investigating and fixing!
squidfunk
approved these changes
Nov 5, 2024
| @@ -467,7 +467,7 @@ def _patch(self, initiator: File): | |||
|
|
|||
| # Replace callback | |||
| def replace(match: Match): | |||
| value = match.group(1) | |||
| value = match.group("url") | |||
There was a problem hiding this comment.
Perfect, thanks for investigating and fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7672
The reproduction repo is provided in #7672.