-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Mermaid 10.6.1 #6265
Conversation
+1 |
Thanks for this PR! Just wanted to mention that Mermaid 10.6.1 was released yesterday. |
Bump the version of Mermaid up to 10.6.1. Per the release notes at https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md the render function is async now, so update to the new async render function. There's also apparently a change to use ESM, but I didn't seem to have any trouble with just bumping the version and updating it to use async. It looks like it's working without any change to how we load it, but I'm not much of a frontend developer so I could be missing something.
af05a5e
to
441e05b
Compare
@manselmi Rebased and updated to pull in 10.6.1 @squidfunk Looks like you're aware of this, are there any concerns that I should address? It should be fairly easy to test out. I saw the discussion about ESM on on other PRs, but there didn't seem to need to be any updates to how this was loaded, and it works in the browsers I have tested. I don't have any older browsers easily available to test against. |
Thanks for the PR! As mentioned in #5758 (comment), I need some time to test this thoroughly. I'm currently focusing on #6307, but as soon as we have a first prototype deployed, I'll take some time to revisit this PR |
So, thanks for your work! This PR looks good, and my testing shows everything we supported up to now is still supported. New diagram types might need additional styles for better integration, so PRs welcome. |
Bump the version of Mermaid up to 10.6.1. Per the release notes at https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md the render function is async now, so update to the new async render function.
There's also apparently a change to use ESM, but I didn't seem to have any trouble with just bumping the version and updating it to use async. It looks like it's working without any change to how we load it, but I'm not much of a frontend developer so I could be missing something.