catching Throwables in RealEventSource #8735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Defination of public open fun onFailure(
eventSource: EventSource,
t: Throwable?,
response: Response?
): Unit |
AlexCue987
reviewed
Apr 11, 2025
| @@ -80,7 +80,7 @@ internal class RealEventSource( | |||
| while (!canceled && reader.processNextEvent()) { | |||
| } | |||
| } | |||
| } catch (e: Exception) { | |||
| } catch (e: Throwable) { | |||
There was a problem hiding this comment.
Is there a reason we want to catch/handle something we cannot recover from, such as an OutOfMemoryError.
There was a problem hiding this comment.
Because the onFailure will re-throw it, with param of Throwable? instead of Exception?
There was a problem hiding this comment.
I responded on the original bug, I don't think we should be surfacing these as if the app can handle and continue. The state of OkHttpClient is probably unknown at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8463