Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Record support #840

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions src/main/java/com/squareup/javapoet/MethodSpec.java
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ private boolean lastParameterIsArray(List<ParameterSpec> parameters) {
&& TypeName.asArray((parameters.get(parameters.size() - 1).type)) != null;
}

void emit(CodeWriter codeWriter, String enclosingName, Set<Modifier> implicitModifiers)
void emit(CodeWriter codeWriter, String enclosingName, Set<Modifier> implicitModifiers,
boolean compactConstructor)
throws IOException {
codeWriter.emitJavadoc(javadocWithParameters());
codeWriter.emitAnnotations(annotations, false);
Expand All @@ -91,22 +92,18 @@ void emit(CodeWriter codeWriter, String enclosingName, Set<Modifier> implicitMod
codeWriter.emit(" ");
}

if (isConstructor()) {
codeWriter.emit("$L($Z", enclosingName);
if (compactConstructor) {
codeWriter.emit("$L", enclosingName);
} else {
codeWriter.emit("$T $L($Z", returnType, name);
}
if (isConstructor()) {
codeWriter.emit("$L", enclosingName);
} else {
codeWriter.emit("$T $L", returnType, name);
}

boolean firstParameter = true;
for (Iterator<ParameterSpec> i = parameters.iterator(); i.hasNext(); ) {
ParameterSpec parameter = i.next();
if (!firstParameter) codeWriter.emit(",").emitWrappingSpace();
parameter.emit(codeWriter, !i.hasNext() && varargs);
firstParameter = false;
emitParameters(codeWriter, parameters, varargs);
}

codeWriter.emit(")");

if (defaultValue != null && !defaultValue.isEmpty()) {
codeWriter.emit(" default ");
codeWriter.emit(defaultValue);
Expand Down Expand Up @@ -141,6 +138,11 @@ void emit(CodeWriter codeWriter, String enclosingName, Set<Modifier> implicitMod
}

private CodeBlock javadocWithParameters() {
return makeJavadocWithParameters(javadoc, parameters);
}

static CodeBlock makeJavadocWithParameters(CodeBlock javadoc,
Iterable<ParameterSpec> parameters) {
CodeBlock.Builder builder = javadoc.toBuilder();
boolean emitTagNewline = true;
for (ParameterSpec parameterSpec : parameters) {
Expand All @@ -154,6 +156,22 @@ private CodeBlock javadocWithParameters() {
return builder.build();
}

static void emitParameters(CodeWriter codeWriter, Iterable<ParameterSpec> parameters,
boolean varargs) throws IOException {
codeWriter.emit(CodeBlock.of("($Z"));

boolean firstParameter = true;
for (Iterator<ParameterSpec> i = parameters.iterator(); i.hasNext(); ) {
ParameterSpec parameter = i.next();
if (!firstParameter)
codeWriter.emit(",").emitWrappingSpace();
parameter.emit(codeWriter, !i.hasNext() && varargs);
firstParameter = false;
}

codeWriter.emit(")");
}

public boolean hasModifier(Modifier modifier) {
return modifiers.contains(modifier);
}
Expand All @@ -177,7 +195,7 @@ public boolean isConstructor() {
StringBuilder out = new StringBuilder();
try {
CodeWriter codeWriter = new CodeWriter(out);
emit(codeWriter, "Constructor", Collections.emptySet());
emit(codeWriter, "Constructor", Collections.emptySet(), false);
return out.toString();
} catch (IOException e) {
throw new AssertionError();
Expand Down
Loading