fix: support for bun/deno via node codepath #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds detection code for Bun and Deno, and uses `fs.readFile` for these platforms as is already done on Node. The `fs` module name carries the `node:` prefix which works on both Bun and Deno. Fixes and closes sqlite#100
|
Working for me downstream with Bun, using If there is a better upstream repo to contribute this to, please let me know :) |
|
This patches Emscripten-generated code, so would be overwritten on every build and could be invalidated by changes in any given Emscripten version. This would need to be fixed in the Emscripten project, not this one. |
|
@sgammon, thanks for this contribution, but as @sgbeal said, this would need fixing in Emscripten. From a quick cursory search, maybe emscripten-core/emscripten#12203 is interesting? |
|
Thanks guys. I hadn't noticed this was generated code under edit. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detection code for Bun and Deno, and uses
fs.readFilefor these platforms as is already done on Node. Thefsmodule name carries thenode:prefix which works on both Bun and Deno.Fixes and closes #100