Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add assets for Tkinter (Windows installer) #14727

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Feb 9, 2021

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Missing files and binaries to be able to import Tkinter

Issue(s) Resolved

Fixes #14385

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v4.2.2 milestone Feb 9, 2021
@dalthviz dalthviz self-assigned this Feb 9, 2021
Installers: Update Windows installer assets
Installers: Update .gitignore rules for Windows installer assets
@dalthviz dalthviz force-pushed the fixes_issue_14385 branch 3 times, most recently from ad34931 to 72bb5ec Compare February 15, 2021 16:44
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dalthviz! This is a great improvement to our installer!

@ccordoba12 ccordoba12 merged commit 471e46c into spyder-ide:4.x Feb 15, 2021
ccordoba12 added a commit that referenced this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants