feat: enhance downloader to support directory structures #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy only Python files from zip download for safety - Preserves user config files (config/apps.yaml etc) - Creates directory structure for python files in subdirs - Ignores cache, backup, and development files This ensures only code gets updated, never user settings.
mgazza
force-pushed
the
feat/enhance-downloader-directory-support
branch
from
456b4ce to
47c1ac3
Compare
apps/predbat/download.py
Outdated
|
|
||
| # Move the file | ||
| if os.path.exists(source): | ||
| os.rename(source, dest) |
There was a problem hiding this comment.
Not sure if rename overwrites
There was a problem hiding this comment.
it works on linux/unix on windows it wont. we should use os.replace
…overwriting - os.rename() fails on Windows when destination exists (raises FileExistsError) - os.replace() provides consistent cross-platform overwrite behavior - Ensures update process works reliably on both Unix and Windows systems - Addresses platform-dependent file overwriting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the auto-updater downloader to use zip-based downloads with Python-only file copying for maximum safety. This naturally supports directory structures while preserving all user configurations.
Problem Solved
utils/*files inPREDBAT_FILESbefore they existconfig/apps.yamlSolution: Safe Zip + Python-Only
Changed to zip-based downloads with selective Python file copying:
*.pyfiles (never config, cache, or other files)utils/*.pyfilesChanges Made
predbat_update_download_zip(): Downloads full repo zip*.pyfiles from extracted ziputils/and copiesutils/*.pyfilesKey Safety Features
✅ Preserves user configs: Never touches
config/apps.yamlor other settings✅ Python code only: Only
*.pyfiles get updated✅ No overwrites: Ignores
.bak, cache, and development files✅ Directory structure: Automatically creates
utils/for OO managers✅ Future-proof: Any new
*.pyfiles or directories work automaticallyWhat Gets Copied
*.pyfiles:predbat.py,config.py,utils.py, etc.*.pyfiles:utils/battery_manager.py, etc.utils/as neededWhat Gets Ignored (for safety)
config/apps.yaml(user settings preserved)__pycache__/,.ruff_cache/(development artifacts).bak,.gitfiles (backup/development files)How It Works
https://github.com/springfall2008/batpred/archive/refs/tags/v8.25.1.zip*.pyfiles fromapps/predbat/and subdirectoriesImpact
This addresses the safety concern while enabling directory support for the OO architecture.
🤖 Generated with Claude Code