Enabling ForkingClientServerIntegrationTestsSupport.java to support starting multiple servers #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxblum
suggested changes
Sep 10, 2019
...ringframework/data/gemfire/tests/integration/ForkingClientServerIntegrationTestsSupport.java
Outdated
Show resolved
Hide resolved
...ringframework/data/gemfire/tests/integration/ForkingClientServerIntegrationTestsSupport.java
Outdated
Show resolved
Hide resolved
...ringframework/data/gemfire/tests/integration/ForkingClientServerIntegrationTestsSupport.java
Outdated
Show resolved
Hide resolved
...ringframework/data/gemfire/tests/integration/ForkingClientServerIntegrationTestsSupport.java
Outdated
Show resolved
Hide resolved
...ringframework/data/gemfire/tests/integration/ForkingClientServerIntegrationTestsSupport.java
Outdated
Show resolved
Hide resolved
jxblum
changed the title
kohlmu-pivotal
force-pushed
the
master
branch
from
b07aa9d to
a3b9626
Compare
the starting of multiple server processes without overwriting the `gemfireServer` property with the last started server. gh spring-projects#11
kohlmu-pivotal
force-pushed
the
master
branch
from
a3b9626 to
3409cc5
Compare
|
Is there any thing left preventing this from being merged? Because it would be great to have this in a release so the WAN examples work correctly. |
jxblum
force-pushed
the
main
branch
2 times, most recently
from
95a67f6 to
5b78c3d
Compare
|
Thank you for the PR. It is already possible to fork multiple Java / JVM processes using the STDG framework; see this test in the Spring Data for Apache Geode (SDG) project. The (future) management of multiple, forked Java / JVM processes by the STDG framework will be handled slightly differently than the logic presented in this PR. In short, it will leverage the Spring |
jxblum
added
wontfix
|
Not accepting any more contributions to this project as it is nearly EOL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling ForkingClientServerIntegrationTestsSupport.java to support the starting of multiple server processes without overwriting the
gemfireServerproperty with the last started server.
gh #11