Fix OAuth2LoginConfigurer AuthenticationProvider decoration #17966
+68
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where
OAuth2LoginConfigurer
was not properly supportingObjectPostProcessor<AuthenticationProvider>
decoration due to type casting issues.Problem
Currently, the
postProcess
method inOAuth2LoginConfigurer
returns concrete types (OAuth2LoginAuthenticationProvider
andOidcAuthorizationCodeAuthenticationProvider
) instead of theAuthenticationProvider
interface. This makes it difficult for users to decorate these providers with customObjectPostProcessor
implementations.Solution
postProcess()
toAuthenticationProvider
interface in both OAuth2 and OIDC authentication provider registrationsObjectPostProcessor<AuthenticationProvider>
implementationsChanges
Code Changes
config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java
AuthenticationProvider
interfaceTest Changes
config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurerTests.java
oauth2LoginWhenOidcAuthenticationProviderPostProcessorThenUses()
test methodOAuth2LoginConfigCustomWithOidcPostProcessor
test configuration classOidcSpyObjectPostProcessor
for testing OIDC provider decorationBenefits
This change enables developers to:
Testing
Related Issue
Closes gh-17357