Add lambda DSL method for featurePolicy #17492
Open
+60
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: spring-projectsgh-17321 Signed-off-by: Andrey Litvitski <[email protected]>
therepanic
commented
Jul 7, 2025
Comment on lines
+45
to
+50
| /** | ||
| * Create a new instance of {@link FeaturePolicyHeaderWriter} | ||
| */ | ||
| public FeaturePolicyHeaderWriter() { | ||
| } | ||
|
|
There was a problem hiding this comment.
PermissionsPolicyHeaderWriter has an empty constructor, while FeaturePolicyHeaderWriter does not. To create a method with a customizer, I created an empty constructor for it. Is that okay?
spring-projects-issues
added
the
status: waiting-for-triage
|
I think it's reasonable that you added the constructor. The default constructor was originally absent to ensure that FeaturePolicyHeaderWriter couldn't be instantiated without explicitly providing policyDirectives at the time of instantiation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: gh-17321