Add RSocketServiceMethod support for Kotlin suspending functions
#35473
+164
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
dmitrysulman
changed the title
RSocketServiceMethod support for suspending functionsRSocketServiceMethod support for Kotlin suspending functions
|
@dmitrysulman hello, dear Dmitry. Can you please also add test cases for streaming? At least requestStream that return Flow. Because I also was doing poc of this feature (just for interest) and Flow return type most probably will be covered by ReactiveAdapterRegistry, but still it is good for it to also be covered by test. And also meanwhile I am not sure if the requestChannel will correctly handle Flow as argument, so also good to be covered with test. Will be very grateful if you have time to add it and thank you for your contribution. |
dmitrysulman
force-pushed
the
rsocket-interface-coroutine
branch
2 times, most recently
from
350082c to
255ef56
Compare
|
@doxlik done, Request Stream and Request Channel suspending functions (using The |
sdeleuze
added
in: messaging
dmitrysulman
commented
Sep 14, 2025
...saging/src/main/java/org/springframework/messaging/rsocket/service/RSocketServiceMethod.java
Outdated
Show resolved
Hide resolved
doxlik
reviewed
Sep 18, 2025
...test/kotlin/org/springframework/messaging/rsocket/service/RSocketServiceMethodKotlinTests.kt
Show resolved
Hide resolved
sdeleuze
removed
the
status: waiting-for-triage
sdeleuze
requested changes
Oct 29, 2025
spring-aop/src/main/java/org/springframework/aop/framework/CoroutinesUtils.java
Outdated
Show resolved
Hide resolved
dmitrysulman
force-pushed
the
rsocket-interface-coroutine
branch
from
255ef56 to
49d92ce
Compare
See spring-projects#34868 Signed-off-by: Dmitry Sulman <[email protected]>
dmitrysulman
force-pushed
the
rsocket-interface-coroutine
branch
from
49d92ce to
4918592
Compare
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Oct 30, 2025
See spring-projectsgh-35473 Signed-off-by: Dmitry Sulman <[email protected]>
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Oct 30, 2025
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Oct 30, 2025
See spring-projectsgh-35473 Signed-off-by: Dmitry Sulman <[email protected]>
sdeleuze
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
RSocketServiceMethodto allow using the@RSocketExchangeannotation with Kotlin suspending functions when used as RSocket requester.Fixes #34868