Fix inconsistent query parameter conversion for String params #34713
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: kssumin <[email protected]>
kssumin
force-pushed
the
fix-inconsistent-query-parameter-conversion-String-param
branch
from
aa5d826 to
90f17a9
Compare
|
Original issue has been declined. #34613 (comment) Thanks for your contribution. |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When converting multiple query parameters with the same name to a single value, Spring behaves inconsistently depending on the target type:
/endpoint?param=1¶m=2→ first value is used (1)/endpoint?param=1¶m=2→ comma-separated string is created (1,2)This inconsistency makes behavior unpredictable and forces developers to implement workarounds.
Changes
This PR modifies
WebRequestDataBinderto handleString[]toStringconversion consistently with other types by only using the first value when binding web request parameters.Tests
Added unit tests to verify consistent behavior across different parameter types.
Fixes #34613