-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include QueryMappingConfiguration for all part tree queries #1893
base: main
Are you sure you want to change the base?
Conversation
a481a59
to
2395100
Compare
Resolved the conflict after |
This PR fails |
@schauder |
There are components (e.g. |
@schauder so, the dependency error was fixed. The solution was to move
to
It seems to make sense, since the What are your thoughts on this? @schauder |
I updated our labels as this change is a breaking one by moving public types around. |
This PR currently does not compile and a naive rebase doesn't work either. Could you take a look @mipo256 please. |
Sure, I would handle it @schauder. Will let you know once it is fixed. |
19d5a82
to
8a167b9
Compare
That is done @schauder |
While it does compile a |
…t tree queries Signed-off-by: mipo256 <[email protected]>
Thank you for pointing this out, that is fixed @schauder |
Solving #1006 issue
To ease the review - actually, we already had the
QueryMappingConfiguration
applied for PartTree queries, but only for those that are declared in the repository and execute viaPartTreeJdbcQuery#execute
. For the predefined methods, that resolve intoSimpleJdbcRepository
methods we did not haveQueryMappingConfiguration
applied. So I've just covered this gap and added some tests to verify the expected behavior.PS: For
StringBasedJdbcQuery
no changes required.