Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access of root property instead of child property #1775

Closed
wants to merge 2 commits into from

Conversation

schauder
Copy link
Contributor

When the child of a one-to-one relationship has an id, the value for that id gets read in the wrong way.
We get the column name for that id use that to access the value in the RowDocument.

This results in either no value at all being found or even worse, the value of a root entity with a property of same name being accessed.

This is fixed by using the full AggregatePath instead of just the property for accessing that value.

Closes #1684

When the child of a one-to-one relationship has an id, the value for that id gets read in the wrong way.
We get the column name for that id use that to access the value in the RowDocument.

This results in either no value at all being found or even worse, the value of a root entity with a property of same name being accessed.

This is fixed by using the full AggregatePath instead of just the property for accessing that value.

Closes #1684
@schauder schauder force-pushed the issue/1684-converter-not-found branch from 6e4dd03 to ea86ec7 Compare April 19, 2024 13:01
@mp911de mp911de added the type: regression A regression from a previous release label Apr 22, 2024
@mp911de mp911de added this to the 3.2.6 (2023.1.6) milestone Apr 22, 2024
mp911de pushed a commit that referenced this pull request Apr 22, 2024
When the child of a one-to-one relationship has an id, the value for that id gets read in the wrong way.
We get the column name for that id use that to access the value in the RowDocument.

This results in either no value at all being found or even worse, the value of a root entity with a property of same name being accessed.

This is fixed by using the full AggregatePath instead of just the property for accessing that value.

Closes #1684
Original pull request: #1775
mp911de pushed a commit that referenced this pull request Apr 22, 2024
When the child of a one-to-one relationship has an id, the value for that id gets read in the wrong way.
We get the column name for that id use that to access the value in the RowDocument.

This results in either no value at all being found or even worse, the value of a root entity with a property of same name being accessed.

This is fixed by using the full AggregatePath instead of just the property for accessing that value.

Closes #1684
Original pull request: #1775
@mp911de mp911de closed this Apr 22, 2024
@mp911de mp911de deleted the issue/1684-converter-not-found branch April 22, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MappedCollection leads to ConverterNotFoundException when upgrading to 3.2
2 participants