Adds support for Redis setGet command #3017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
requested changes
Oct 10, 2024
| @@ -62,15 +63,23 @@ class SetCommand extends KeyCommand { | |||
| private @Nullable ByteBuffer value; | |||
| private Expiration expiration; | |||
| private SetOption option; | |||
| private boolean get; | |||
There was a problem hiding this comment.
That isn't going to work as the set API returns a boolean response.
| * @see <a href="https://redis.io/commands/set">Redis Documentation: SET</a> | ||
| * @since 3.4 | ||
| */ | ||
| Flux<ByteBufferResponse<SetCommand>> setGet(ByteBuffer key, ByteBuffer value, Expiration expiration, SetOption option); |
There was a problem hiding this comment.
Here we need both signatures, Mono<ByteBuffer> setGet(ByteBuffer key, ByteBuffer value, Expiration expiration, SetOption option) { and Flux<ByteBufferResponse<SetCommand>> set(Publisher<SetCommand> commands);
The first one delegates to the latter.
| * @see <a href="https://redis.io/commands/set">Redis Documentation: SET</a> | ||
| * @since 3.4 | ||
| */ | ||
| V setGet(K key, V value, long timeout, TimeUnit unit); |
There was a problem hiding this comment.
You might want to update BoundValueOperations (the interface) and ReactiveValueOperations as well.
|
Changes applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2853