Fix quoted variable reference in documentation#2850
Closed
1autodidact wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix quoted variable reference in documentation#28501autodidact wants to merge 1 commit intospring-projects:mainfrom
1autodidact wants to merge 1 commit intospring-projects:mainfrom
Conversation
Overview This PR addresses a small issue in the loadHash method of the HashMapping class where the hardcoded string "key" was used instead of the parameter key when retrieving a hash from Redis. Description In the loadHash method of the HashMapping class, the hardcoded string "key" was used to retrieve the hash from Redis instead of utilizing the parameter key provided to the method. This PR corrects this issue by modifying the method call to use the provided key parameter, ensuring the correct hash is loaded. Changes Made Updated the loadHash method in the HashMapping class to use the provided key parameter when retrieving the hash from Redis, replacing the hardcoded string "key". Testing No new functionality is introduced with this change, and existing unit tests cover the modified method. Tests have been run locally to ensure that the correct hash is loaded using the provided key parameter. Request for Review I kindly request a review of this PR. Your feedback is greatly appreciated. Thank you for your time and consideration.
Member
|
LGTM - thanks for spotting! |
mp911de
pushed a commit
that referenced
this pull request
Mar 4, 2024
Member
|
Thank you for your contribution. That's merged and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses a small issue in the loadHash method of the HashMapping class where the hardcoded string "key" was used instead of the parameter key when retrieving a hash from Redis.
Description
In the loadHash method of the HashMapping class, the hardcoded string "key" was used to retrieve the hash from Redis instead of utilizing the parameter key provided to the method. This PR corrects this issue by modifying the method call to use the provided key parameter, ensuring the correct hash is loaded.
Changes Made
Updated the loadHash method in the HashMapping class to use the provided key parameter when retrieving the hash from Redis, replacing the hardcoded string "key". Testing
No new functionality is introduced with this change, and existing unit tests cover the modified method. Tests have been run locally to ensure that the correct hash is loaded using the provided key parameter.
Request for Review
I kindly request a review of this PR. Your feedback is greatly appreciated. Thank you for your time and consideration.