Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Converters.java #2846

Closed
wants to merge 3 commits into from
Closed

Update Converters.java #2846

wants to merge 3 commits into from

Conversation

lightistor
Copy link

@lightistor lightistor commented Feb 15, 2024 •
edited
Loading

Clean extra character in Cluster Node Line Entry for Google Cloud Platform Memory Store Redis when using the Jedis Connector. Sample entries causing ClusterNode information does not define host and port: 3765733728631672640db35fd2f04743c03119c6 10.180.0.33:11003@16379, master - 0 1708041426947 2 connected 5462-10922

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@lightistor
Update Converters.java
1797c01 
Clean extra character in Cluster Node Line Entry for Google Cloud Platform Memory Store Redis when using the Jedis Connector. Sample entries causing ClusterNode information does not define host and port:
3765733728631672640db35fd2f04743c03119c6 10.180.0.33:11003@16379, master - 0 1708041426947 2 connected 5462-10922
@pivotal-cla
Copy link

@lightistor Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@lightistor Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 16, 2024
@lightistor
Copy link
Author

@christophstrobl and @mp911de this is a fix to handle the format of the Cluster Node Line Entry for Google Cloud Platform Memory Store Redis that we are integrating our services with.
is it possible for me get assistance in merging this as a nightly build so that it is publicly available as opposed to us having have to host this fork internally?

@lightistor lightistor mentioned this pull request Mar 4, 2024
Closed
@mp911de
Copy link
Member

mp911de commented Mar 4, 2024

Please provide a test case so that we document what isn't working right now for you and what should work. Also, source..replace is a syntax error introduced with this PR.

@mp911de mp911de self-assigned this Mar 4, 2024
@lightistor
Update Converters.java
efedefd 
fix typo in Converters.java
add unit test for the replace for cleaning empty human readable field

Clean extra character in Cluster Node Line Entry for Google Cloud Platform Memory Store Redis when using the Jedis Connector. Sample entries causing ClusterNode information does not define host and port:
3765733728631672640db35fd2f04743c03119c6 10.180.0.33:11003@16379, master - 0 1708041426947 2 connected 5462-10922
@lightistor
Merge remote-tracking branch 'origin/patch-1' into patch-1
d361c52 
# Conflicts:
#	src/main/java/org/springframework/data/redis/connection/convert/Converters.java
@lightistor
Copy link
Author

Please provide a test case so that we document what isn't working right now for you and what should work. Also, source..replace is a syntax error introduced with this PR.

fixed the typo, added the unit test (toSetOfRedisClusterNodesShouldConvertNodesWithEmptyHumanReadableClusterNameInGcpMemoryStoreCorrectly, uses the entry format CLUSTER_NODE_ENTRY_WITH_EMPTY_HUMAN_READABLE_CLUSTER_NAME_IN_GCP_MEMORY_STORE)
and added myself to the authors in the header (per the checklist)

@mp911de mp911de linked an issue Mar 4, 2024 that may be closed by this pull request
Can't Handle GCP Memory Store Redis having extra characters in ClusterNode Entry #2862
Closed
@lightistor
Copy link
Author

So, what is the possibility of it getting merged one day @mp911de ?

mp911de
mp911de reviewed Sep 10, 2024
View reviewed changes
src/main/java/org/springframework/data/redis/connection/convert/Converters.java
@@ -569,8 +570,9 @@ enum ClusterNodesConverter implements Converter<String, RedisClusterNode> {

@Override
public RedisClusterNode convert(String source) {

String[] args = source.split(" ");
String filteredSource = source.replace(", ", " ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't do the job especially when auxilliary fields are appended, then the port part is immediately followed by aux fields.

@mp911de
Copy link
Member

mp911de commented Sep 10, 2024

This PR isn't going anywhere really and the proposed fix is not addressing the underlying issue. As it would require a lot of effort from our side to fix and address shortcomings, we're instead closing this PR without a merge.

@mp911de mp911de closed this Sep 10, 2024
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 10, 2024
@mp911de mp911de removed a link to an issue Sep 10, 2024
Can't Handle GCP Memory Store Redis having extra characters in ClusterNode Entry #2862
Closed
@lightistor lightistor deleted the patch-1 branch September 20, 2024 10:09
@lightistor
Copy link
Author

You are right it went no where without any concrete communication, in the time it took to get a response here, we had a temporary fix in the code and then got Google to patch the MemoryStore for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lightistor @pivotal-cla @mp911de @spring-projects-issues