Support for key containing colons.

[home-body]

#2096
I think this can be solved, please check.

• You have read the Spring Data contribution guidelines.
• You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
• You submit test cases (unit or integration tests) that back your changes.
• You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

[pivotal-cla]

@home-body Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@home-body Thank you for signing the Contributor License Agreement!

[gpizarro-gfm]

@home-body Thanks for taking a look. Do you have an ETA for which release might include this fix?

[mp911de]

Thank you @home-body for looking into this issue. Our entire code assumes double-colon (:) as a separator between the keyspace and any identifier so the entire codebase contains usage of double-colon. We use multiple levels of information when it comes to keys/identifiers (the actual hash, secondary indexes) and we cannot simply assume that the last part of any given identifier is going to be the thing we're looking for.

In fact, to enable double-colon to be used in the keyspace attribute, we need to revisit and update all places that work with identifiers to introduce an abstraction to properly create and introspect identifiers.

The submitted changes do not cover the full range of changes that are required to make this work. For the time being, please avoid using : in the keyspace name and we're closing this pull request without a merge.