-
Notifications
You must be signed in to change notification settings - Fork 310
Adopt to AOT changes in Commons #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
onobc
wants to merge
2
commits into
spring-projects:5.0.x
Choose a base branch
from
onobc:issue/GH-1566
base: 5.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+562
−9
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
...gframework/data/cassandra/repository/support/CassandraRepositoryFragmentsContributor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
/* | ||
* Copyright 2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.springframework.data.cassandra.repository.support; | ||
|
||
import org.springframework.data.cassandra.core.CassandraOperations; | ||
import org.springframework.data.cassandra.repository.query.CassandraEntityInformation; | ||
import org.springframework.data.repository.core.RepositoryMetadata; | ||
import org.springframework.data.repository.core.support.RepositoryComposition.RepositoryFragments; | ||
import org.springframework.data.repository.core.support.RepositoryFragmentsContributor; | ||
import org.springframework.util.Assert; | ||
|
||
/** | ||
* Cassandra-specific {@link RepositoryFragmentsContributor} contributing fragments based on the repository. | ||
* <p> | ||
* Implementations must define a no-args constructor. | ||
* | ||
* @author Chris Bono | ||
* @since 5.0 | ||
*/ | ||
public interface CassandraRepositoryFragmentsContributor extends RepositoryFragmentsContributor { | ||
|
||
CassandraRepositoryFragmentsContributor DEFAULT = DefaultCassandraRepositoryFragmentsContributor.INSTANCE; | ||
|
||
/** | ||
* Returns a composed {@code CassandraRepositoryFragmentsContributor} that first applies this contributor to its inputs, | ||
* and then applies the {@code after} contributor concatenating effectively both results. If evaluation of either | ||
* contributors throws an exception, it is relayed to the caller of the composed contributor. | ||
* | ||
* @param after the contributor to apply after this contributor is applied. | ||
* @return a composed contributor that first applies this contributor and then applies the {@code after} contributor. | ||
*/ | ||
default CassandraRepositoryFragmentsContributor andThen(CassandraRepositoryFragmentsContributor after) { | ||
|
||
Assert.notNull(after, "CassandraRepositoryFragmentsContributor must not be null"); | ||
|
||
return new CassandraRepositoryFragmentsContributor() { | ||
|
||
@Override | ||
public RepositoryFragments contribute(RepositoryMetadata metadata, | ||
CassandraEntityInformation<?, ?> entityInformation, CassandraOperations operations) { | ||
return CassandraRepositoryFragmentsContributor.this.contribute(metadata, entityInformation, operations) | ||
.append(after.contribute(metadata, entityInformation, operations)); | ||
} | ||
|
||
@Override | ||
public RepositoryFragments describe(RepositoryMetadata metadata) { | ||
return CassandraRepositoryFragmentsContributor.this.describe(metadata).append(after.describe(metadata)); | ||
} | ||
}; | ||
} | ||
|
||
/** | ||
* Creates {@link RepositoryFragments} based on {@link RepositoryMetadata} to add | ||
* Cassandra-specific extensions. | ||
* | ||
* @param metadata repository metadata. | ||
* @param entityInformation must not be {@literal null}. | ||
* @param operations must not be {@literal null}. | ||
* @return {@link RepositoryFragments} to be added to the repository. | ||
*/ | ||
RepositoryFragments contribute(RepositoryMetadata metadata, | ||
CassandraEntityInformation<?, ?> entityInformation, CassandraOperations operations); | ||
|
||
/** | ||
* Implementation of {@link CassandraRepositoryFragmentsContributor} that contributes empty fragments by default. | ||
* | ||
* @author Chris Bono | ||
* @since 5.0 | ||
*/ | ||
enum DefaultCassandraRepositoryFragmentsContributor implements CassandraRepositoryFragmentsContributor { | ||
|
||
INSTANCE; | ||
|
||
@Override | ||
public RepositoryFragments contribute(RepositoryMetadata metadata, | ||
CassandraEntityInformation<?, ?> entityInformation, CassandraOperations operations) { | ||
return RepositoryFragments.empty(); | ||
} | ||
|
||
@Override | ||
public RepositoryFragments describe(RepositoryMetadata metadata) { | ||
return RepositoryFragments.empty(); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventhough the fragment are empty by default for Cassandra, I chose to create a default impl that simple returned empty() to serve as a non-null fragmentsContributor default in the factory/factoryBeans as well as a placeholder in case we add default fragments (e.g. the MongoDB queryDsl fragments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to have the same extension points across our Spring Data modules. Having the enum inside the interface makes it public. I suggest having a package-protected visibility for the default implementation.