Skip to content

Remove unnused parameter in ManifestLayerArchiveFactory #47694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove unnused parameter in ManifestLayerArchiveFactory #47694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...rm/src/main/java/org/springframework/boot/buildpack/platform/docker/ExportedImageTar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ static LayerArchiveFactory create(ImageReference reference, Path tarFile) throws
if (index != null) {
return new IndexLayerArchiveFactory(tarFile, index);
}
Assert.state(manifest != null, "'manifest' must not be null");
return new ManifestLayerArchiveFactory(tarFile, manifest);
return new ManifestLayerArchiveFactory(manifest);
}
}

Expand Down Expand Up @@ -270,7 +269,7 @@ private static class ManifestLayerArchiveFactory extends LayerArchiveFactory {

private final Set<String> layers;

ManifestLayerArchiveFactory(Path tarFile, ImageArchiveManifest manifest) {
Copy link
Author

@Pankraz76 Pankraz76 Oct 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this important?

sometimes these unused fields relate to some kind of bug:

ManifestLayerArchiveFactory(ImageArchiveManifest manifest) {
this.layers = manifest.getEntries()
.stream()
.flatMap((entry) -> entry.getLayers().stream())
Expand Down