Skip to content

Conversation

SSUday
Copy link

@SSUday SSUday commented Sep 18, 2025

Problem:
Micrometer added an option to register JCache removals as a function counter.
In Boot, users cannot provide a custom JCacheCacheMeterBinderProvider because
our auto-configured provider wasn’t conditional on a user bean.

Solution:

  • Annotate the auto-configured provider with @ConditionalOnMissingBean(JCacheCacheMeterBinderProvider.class)
  • Add JCacheCacheMeterBinderProviderBackOffTests to prove a user bean is used.

Risk/Docs:

  • Backwards-compatible; only changes selection order.
  • No docs changes needed.

Fixes #46212

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 18, 2025
@SSUday SSUday force-pushed the feature/jcache-backoff branch from b4933e3 to 714213c Compare September 18, 2025 18:52
@SSUday SSUday force-pushed the feature/jcache-backoff branch from 714213c to ba1627b Compare September 18, 2025 18:57
@snicoll
Copy link
Member

snicoll commented Sep 18, 2025

Thanks for the PR but it isn't actionable. The issue you've referenced is pending design work, which means we need to figure out what we wan to do before work can start.

@snicoll snicoll closed this Sep 18, 2025
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants