Skip to content

Remove unnecessary reflection in RemoteChunkHandlerFactoryBean #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unnecessary reflection in RemoteChunkHandlerFactoryBean #4839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .../main/java/org/springframework/batch/integration/chunk/RemoteChunkHandlerFactoryBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,12 @@ public ChunkHandler<T> getObject() throws Exception {
stepContributionSource = (StepContributionSource) chunkWriter;
}

Assert.state(step instanceof TaskletStep, "Step [" + step.getName() + "] must be a TaskletStep");
Assert.state(step != null, "A TaskletStep must be provided");
if (logger.isDebugEnabled()) {
logger.debug("Converting TaskletStep with name=" + step.getName());
}

Tasklet tasklet = getTasklet(step);
Tasklet tasklet = step.getTasklet();
Assert.state(tasklet instanceof ChunkOrientedTasklet<?>,
"Tasklet must be ChunkOrientedTasklet in step=" + step.getName());

Expand Down Expand Up @@ -227,15 +227,6 @@ private ChunkProcessor<T> getChunkProcessor(ChunkOrientedTasklet<?> tasklet) {
return (ChunkProcessor<T>) getField(tasklet, "chunkProcessor");
}

/**
* Pull a Tasklet out of a step.
* @param step a TaskletStep
* @return the Tasklet
*/
private Tasklet getTasklet(TaskletStep step) {
return (Tasklet) getField(step, "tasklet");
}

private static Object getField(Object target, String name) {
Assert.notNull(target, "Target object must not be null");
Field field = ReflectionUtils.findField(target.getClass(), name);
Expand Down
Loading