Fix Azure OpenAI auto-configuration #4636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nAiChatAutoConfiguration Signed-off-by: Willams <[email protected]>
|
@nnam-droid12 now that you removed |
Signed-off-by: Willams <[email protected]>
|
Thanks @ielatif for the feedback! |
Signed-off-by: Willams <[email protected]>
| @@ -1,19 +1,3 @@ | |||
| /* | |||
There was a problem hiding this comment.
We should keep the copyright header. Will add it back when merging.
There was a problem hiding this comment.
Thanks @ilayaperumalg I appreciate the review, noted on the copyright header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #4494
(raised by @Kehrlann)
This PR refactors the Azure OpenAI auto-configuration module to align with Spring Boot’s recommended practices and improve maintainability and configurability.
Changes
Removed unnecessary @ImportAutoConfiguration annotation from AzureOpenAiChatAutoConfiguration.
Ensures that users can exclude ToolCallingAutoConfiguration independently when using Azure OpenAI configuration.
Maintains proper ordering with @autoConfiguration(after = { ToolCallingAutoConfiguration.class }).