Make most of Builders final #4578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a low hanging fruit change to make most of the Builders we have final, according to our recent design choice. A handful of Builders are left non-final because they we involved in a class hierarchy already. Signed-off-by: Eric Bottard <[email protected]>
sunyuhan1998
approved these changes
Oct 10, 2025
|
LGTM, merging. |
|
Rebased and merged as 0403a2a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a low hanging fruit change to make most of the Builders we have final, according to our recent design choice. A handful of Builders are left non-final because they we involved in a class hierarchy already.