Issue 3884 Improve tool parameter conversion error messages #3970
+487
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances error handling for tool parameter type conversion failures by providing detailed, actionable error messages when the model returns
values that cannot be converted to expected parameter types (e.g., empty strings for numeric parameters).
Changes
Error Message Examples
Before:
java.lang.NumberFormatException: null
After:
Tool parameter conversion failed for parameter 'userId' in tool 'getUserData':
Expected type: Long, but received: "" (empty string)
Suggestion: Ensure your prompt clearly specifies that numeric parameters should contain valid numbers, not empty strings.
Consider making the parameter optional or providing a default value in your tool description.
Testing
Signed-off-by: Mattia Pasetto [email protected]
I am still pretty new to contributions, please double check and let me know of any errors.