Create new ToolChatOptions if input request has tool configuration without options #3397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijit219
approved these changes
Jun 2, 2025
markpollack
reviewed
Jul 17, 2025
| @@ -685,7 +689,7 @@ public List<Media> getMedia() { | |||
| return this.media; | |||
| } | |||
|
|
|||
| public List<String> getToolNames() { | |||
There was a problem hiding this comment.
Set maybe more appropriate ,but at this point since it is GA, we can't change the API without doing a deprecation first. Probably isn't worth the hastle to change to Set
There was a problem hiding this comment.
Is the DefaultChatClientRequestSpec part of the API? I changed it to Set since the public API is actually using a Set. e.g. in DefaultToolCallingChatOptions also the ToolCallingChatOptions#toolNames.
In any case, you are right. I have reverted that change
filiphr
force-pushed
the
provide-tool-options-when-no-options-are-set
branch
from
f458765 to
74e3d25
Compare
|
Seems like the failing test is failing on main as well. |
…thout options Signed-off-by: Filip Hrisafov <[email protected]>
Signed-off-by: Filip Hrisafov <[email protected]>
filiphr
force-pushed
the
provide-tool-options-when-no-options-are-set
branch
from
74e3d25 to
67b962f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the tool information is not provided to the underlying client if the prompt does not have any chat options set.
e.g.
The example above will not provide the tool name to the underlying chat model through the request.