make responseMessage in AzureOpenAiChatModel.buildGeneration null-safe #2789
+36
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berjan Jonker <[email protected]>
markpollack
reviewed
Apr 21, 2025
| @@ -106,6 +107,26 @@ void testMessageHistory() { | |||
| assertThat(response.getResult().getOutput().getText()).containsAnyOf("Blackbeard"); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
This test passes without the fix to the ChatModel, so I'm not sure what to make of it. Perhaps this is an intermittent error in what the model returns?
There was a problem hiding this comment.
See comments in #2691 (comment) as well.
There was a problem hiding this comment.
As explained in #2691 this PR fixes a NPE when Asynchronous Filter is enabled for your model. As it fixes the streaming output, I don't know for sure if the content filtering works as expected with this option enabled.
|
Fantastic, thanks so much for the investigation and the PR, it is now merged. merged in af0303f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2691