fix(openai): prevent incorrect ToolCall merging caused by empty id and name strings #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I shaded this change in to test since I have similar issue. We should also look to fix for toolname being blank - line 147 specifically. When i did same has text check, it made the merge work even when name was not present. Possibly worth adding that into this fix as well. |
yangtuooc
changed the title
yangtuooc
force-pushed
the
GH-2417
branch
2 times, most recently
from
b833451 to
c9e1077
Compare
…d name strings Empty tool call id and name strings causing improper ToolCall merging during OpenAI stream processing, resulting in incorrect function calling responses. This fix ensures both null and empty strings are properly validated before merging operations. Fixes spring-projectsGH-2417 (spring-projects#2417) Fixes spring-projectsGH-2423 (spring-projects#2423) Signed-off-by: Wenhao Ma <[email protected]>
|
@yangtuooc Thanks for fixing the issue. Rebased and merged as e888895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty tool call id and name strings causing improper ToolCall merging during OpenAI stream
processing, resulting in incorrect function calling responses. This fix ensures both null
and empty strings are properly validated before merging operations.
Fixes #2417 (#2417)
Fixes #2423 (#2423)