feat(js): add sticky assignment support through remote resolver fallback #48
+425
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
commented
Oct 13, 2025
openfeature-provider/js/examples/FileBackedMaterializationRepo.ts
Outdated
Show resolved
Hide resolved
nicklasl
changed the title
There was a problem hiding this comment.
There is still a lot of references to MaterializationRepository etc? Basically I don't expect any changes to public API at this point?
When it comes to tests I think we should focus on a few tests that verify the fallback works. Since this PR was opened there has been a lot of new network tests added that with test-helpers that mock the whole network. Should come in handy for this!
nicklasl
changed the title
|
|
||
| --- | ||
|
|
||
| ## Sticky Assignments |
There was a problem hiding this comment.
I think the docs are good, but could do a little more to explain that currently it comes with a drastic latency penalty? Like a styled info box.
- Add sticky resolve support for materialized assignments - Implement RemoteResolverFallback as default strategy - Simplify public API to accept MaterializationRepository - Add router configuration for flags resolve endpoint 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> refactor: remove references to materialization repo test: changed tests
test: run e2e tests during make test ci: pass the environment vars into docker
feat: add e2e test support in Docker builds - Add all-e2e target that runs e2e tests with credentials - Default docker build skips e2e tests (no credentials needed) - CI runs all-e2e target with GitHub secrets - E2E tests skip gracefully when credentials not provided 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds sticky assignment support to the JavaScript OpenFeature provider using remote resolver fallback.
How it works
Key changes
ResolveWithStickyRequestsupport in provider🤖 Generated with Claude Code