Skip to content

Conversation

@Vampire
Copy link
Member

@Vampire Vampire commented Nov 14, 2025

No description provided.

Copy link
Member Author

Vampire commented Nov 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.07%. Comparing base (158e2e4) to head (c616136).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2262   +/-   ##
=========================================
  Coverage     82.07%   82.07%           
+ Complexity     4754     4753    -1     
=========================================
  Files           465      465           
  Lines         14872    14872           
  Branches       1877     1877           
=========================================
  Hits          12206    12206           
  Misses         1978     1978           
  Partials        688      688           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,34 @@
def springVersion = "7.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be good to move the version into the libs.versions.toml, and use it there in a dependency, just do make it updateable via renovate, something like spring7Versionsimilar to junit?

testImplementation projects.spockSpring
testImplementation libs.junit4
testImplementation "org.springframework:spring-context"
testImplementation("org.springframework:spring-test")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make is same as the other dependencies.

Suggested change
testImplementation("org.springframework:spring-test")
testImplementation "org.springframework:spring-test"


testImplementation projects.spockCore
testImplementation projects.spockSpring
testImplementation libs.junit4
Copy link
Member

@AndreasTu AndreasTu Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use Junit4 here?
Is it due to the SpringRunnerTest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. -:-D
I just copied the spring6 to spring7 and the boot3 to boot4, changed the packages and made the adjustments to make them run.
So everything you said in both PRs is probably valid (didn't look in detail yet) but also for the existing projects.

@AndreasTu
Copy link
Member

There is also the new version missing in spock-spring\spring.gradle, where there is a Set of versions to test.

@AndreasTu
Copy link
Member

AndreasTu commented Nov 15, 2025

When I execute gradlew :spock-spring:check locally with Java 21, it already fails for the task spring6Test, but it works with Java 17.

It seams that there is already a regression with Java 21 and spring 6:

org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'org.spockframework.spring.Service2' available: expected single matching bean but found 4: org.spockframework.spring.Service2#0,org.spockframework.spring.Service2#1,org.spockframework.spring.Service2#2,aName

https://ge.spockframework.org/s/f5cvzjnfzd3da

Note: I also needed to adapt the line in spring.gradle to "6.0.0": (17..21),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants