-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nterl0k - T1595 - Generic Scanning Behavior #3253
Merged
patel-bhavin
merged 6 commits into
splunk:develop
from
nterl0k:nterl0k-t1595-generic-scanner
Jan 6, 2025
Merged
Nterl0k - T1595 - Generic Scanning Behavior #3253
patel-bhavin
merged 6 commits into
splunk:develop
from
nterl0k:nterl0k-t1595-generic-scanner
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the yaml file name and other meta data to ensure it builds succesfully
Removed T1423 since that id is for Mobile
Groovy, thanks for the touch up!
Regards,
Steven.
…-------- Original message --------
From: Bhavin Patel ***@***.***>
Date: 1/3/25 2:56 PM (GMT-05:00)
To: splunk/security_content ***@***.***>
Cc: Steven Dick ***@***.***>, Mention ***@***.***>
Subject: Re: [splunk/security_content] Nterl0k - T1595 - Generic Scanning Behavior (PR #3253)
Hello @nterl0k<https://github.com/nterl0k> : Long time no see! Happy new year there! Thank you for the PR, i made a minor update to the data_source key and other minor fixes : 39842b9<39842b9>
I have merged the corresponding attack data PR to continue with unit-testing!
—
Reply to this email directly, view it on GitHub<#3253 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJIYP7XXM4AXC6ZGXZVGI2L2I3TPJAVCNFSM6AAAAABUHPO4ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZG42DGNBYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
patel-bhavin
approved these changes
Jan 6, 2025
The testing looks good! Thank you @nterl0k! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Just a simple generic scanning behavior detection from Sysmon EID3 events. Optimized using Traffic datamodel.
Pending - splunk/attack_data#922
Checklist
<platform>_<mitre att&ck technique>_<short description>
nomenclatureNotes For Submitters and Reviewers
build
CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.