Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Solarized themes #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added the Solarized themes #361

wants to merge 1 commit into from

Conversation

bridgesense
Copy link

Images of the Light and Dark themes from the default MUD entry.

screen shot 2016-07-25 at 2 13 58 pm

screen shot 2016-07-25 at 2 14 42 pm

@jhersh
Copy link
Member

jhersh commented Jul 25, 2016

Thanks so much @bridgesense! I'm a fan of Solarized and this is really great to see. I am uncertain whether this complies with Solarized's license and developer guidelines.

Solarized defines itself as:

Solarized is a sixteen color palette (eight monotones, eight accent colors) designed for use with terminal and gui applications. It has several unique properties.

Themes in MUDRammer are really just a background color plus a default text color for uncolored text. MUDRammer uses its own ANSI-16 (and xterm-256) text colors that are the same across all of MUDRammer's themes. Given that we are only taking foreground and default text colors from Solarized, and we're not using the rest of its color palette, are we justified in calling these themes in MUDRammer "Solarized" and "Solarized Dark"?

The Solarized Developer notes include this guideline:

No hue or color changes.

This PR takes Solarized's background and primary text colors and uses them with MUDRammer's own text colors. Does this violate Solarized's developer guidelines?

Maybe @altercation can help answer these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants