Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate cargo into cmake build #2690

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Conversation

0ax1
Copy link
Member

@0ax1 0ax1 commented Mar 13, 2025

No description provided.

@0ax1 0ax1 marked this pull request as ready for review March 13, 2025 15:43
@0ax1 0ax1 requested a review from joseph-isaacs March 13, 2025 15:43
Comment on lines +32 to +33
target_link_libraries(${EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto vortex_duckdb-static)
target_link_libraries(${LOADABLE_EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto vortex_duckdb-shared)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can kill these now

Copy link
Member Author

@0ax1 0ax1 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we link the vortex_duckdb rust lib against the extension.

E.g. build_static_extension defines a library target ${NAME}_extension.

function(build_static_extension NAME PARAMETERS)
  # all parameters after name
  set(FILES "${ARGV}")
  list(REMOVE_AT FILES 0)
  add_library(${NAME}_extension STATIC ${FILES})
  target_link_libraries(${NAME}_extension duckdb_static)
endfunction()

We link the Rust lib against ${NAME}_extension.

@0ax1 0ax1 enabled auto-merge (squash) March 13, 2025 15:57
@0ax1 0ax1 merged commit 033e61a into develop Mar 13, 2025
27 checks passed
@0ax1 0ax1 deleted the ad/port-rs-code-to-cxx-extension branch March 13, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants