Compressed Statistics #2686
Merged
Compressed Statistics #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onursatici
approved these changes
Mar 13, 2025
| @@ -34,7 +35,7 @@ impl LayoutStrategy for VortexLayoutStrategy { | |||
| ctx.clone(), | |||
| &DType::Null, | |||
| ChunkedLayoutOptions { | |||
| chunk_strategy: Arc::new(FlatLayoutOptions::default()), | |||
| chunk_strategy: ArcRef::new_arc(Arc::new(FlatLayoutOptions::default()) as _), | |||
There was a problem hiding this comment.
Suggested change
| chunk_strategy: ArcRef::new_arc(Arc::new(FlatLayoutOptions::default()) as _), | |
| chunk_strategy: ArcRef::new_arc(Arc::new(FlatLayoutOptions::default())), |
robert3005
reviewed
Mar 13, 2025
| @@ -44,9 +41,8 @@ impl LayoutVTable for ChunkedLayout { | |||
| row_offset: u64, | |||
| splits: &mut BTreeSet<u64>, | |||
| ) -> VortexResult<()> { | |||
| let nchunks = layout.nchildren() - (if layout.metadata().is_some() { 1 } else { 0 }); | |||
There was a problem hiding this comment.
why is this no longer necessary? It's a bit cheeky to register splits of stats table?
There was a problem hiding this comment.
Chunked array no longer had a stats table, move to stats layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compress the stats tables