fix: Generate S3 tpch data fixes for runson runners #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwwmanning
reviewed
Mar 11, 2025
| aws s3 cp --recursive bench-vortex/data/tpch/1 $REMOTE_PATH | ||
| # We can now clear generated data | ||
| rm -rf bench-vortex/data/ | ||
| aws s3 cp --recursive bench-vortex/data/tpch/1 s3://vortex-bench-dev-eu/tpch-sf1/ |
There was a problem hiding this comment.
AFAIK this will only delete old files iff we have new file with exact same name. Probably true but... maybe a source of bugs in the future?
There was a problem hiding this comment.
I think we will need a more elaborate setup in the future. This is good enough for now. We need to make a proper bench crate that will sync files with expected state
robert3005
force-pushed
the
rk/generatetpchS3
branch
from
da58661 to
ae27c1b
Compare
lwwmanning
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.