feat(core): Re-introduce executionEngine flag, add ExecutionEngineRunner that selects an underlying ExecutionRunner based on the specified ExecutionEngine #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
force-pushed
the
execution-engine
branch
2 times, most recently
from
0646923 to
7c67278
Compare
…ner that selects an underlying ExecutionRunner based on the specified ExecutionEngine
jonsie
force-pushed
the
execution-engine
branch
from
7c67278 to
5aeb61a
Compare
srekapalli
reviewed
Oct 30, 2020
| import com.netflix.spinnaker.orca.api.pipeline.models.PipelineExecution | ||
| import com.netflix.spinnaker.orca.pipeline.ExecutionRunner | ||
| import com.netflix.spinnaker.orca.api.pipeline.models.ExecutionEngine.v3 | ||
| import com.netflix.spinnaker.q.Queue | ||
| import com.netflix.spinnaker.security.AuthenticatedRequest | ||
| import org.springframework.stereotype.Component | ||
|
|
||
| @Component |
There was a problem hiding this comment.
Just curious. We drive the decision of what runner to use based on the annotation being present ..?
There was a problem hiding this comment.
Yeah, I could change that if we don't like it but it seemed to make sense to me. I didn't want to add a field to ExecutionRunner since the composite ExecutionEngineRunner takes a list of ExecutionRunner objects.
robzienert
approved these changes
Oct 30, 2020
|
|
||
| import com.netflix.spinnaker.orca.api.pipeline.models.PipelineExecution; | ||
| import javax.annotation.Nonnull; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| /** The touch point into running a {@link PipelineExecution}. */ |
There was a problem hiding this comment.
Can we get some docs on the method as well?
| @@ -0,0 +1,18 @@ | |||
| package com.netflix.spinnaker.orca.api.pipeline.models; | |||
|
|
|||
| public enum ExecutionEngine { | |||
Comment on lines
+70
to
+71
| new UnsupportedOperationException( | ||
| "No execution engine runner found!"))); |
There was a problem hiding this comment.
Use a subtype of SystemException?
...ore/src/test/groovy/com/netflix/spinnaker/orca/pipeline/CompoundExecutionOperatorSpec.groovy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back the flag that was removed here: https://github.com/spinnaker/orca/pull/1917/files
Also moves the
ExecutionRunnerinterface toorca-apiand introduces a compositeExecutionRunnerclassExecutionEngineRunner.This allows us to experiment with a
v4execution engine.