Skip to content

Commit

Permalink
fix(build): remove dokka plugin since it doesn't work with java 17 (#…
Browse files Browse the repository at this point in the history
…4753)

From e.g. https://github.com/spinnaker/orca/actions/runs/9507661391/job/26207523287:

Caused by: java.lang.NoSuchMethodError: 'org.jetbrains.dokka.model.DInterface org.jetbrains.dokka.model.DInterface.copy$default(org.jetbrains.dokka.model.DInterface, org.jetbrains.dokka.links.DRI, java.lang.String, java.util.Map, org.jetbrains.dokka.DokkaConfiguration$DokkaSourceSet, java.util.Map, java.util.List, java.util.List, java.util.List, java.util.Map, org.jetbrains.dokka.model.DObject, java.util.List, java.util.Map, java.util.Set, boolean, org.jetbrains.dokka.model.properties.PropertyContainer, int, java.lang.Object)'

Note that this github action didn't do anything when it succeeded.  From e.g. https://github.com/spinnaker/orca/actions/runs/9505579020/job/26200789091:

Branch 'create-pull-request/patch' is not ahead of base 'master' and will not be created

Co-authored-by: Jason <[email protected]>
  • Loading branch information
dbyron-sf and jasonmcintosh authored Jun 25, 2024
1 parent 33a7db3 commit 61e3762
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 89 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Build
env:
ORG_GRADLE_PROJECT_version: ${{ steps.build_variables.outputs.VERSION }}
run: ./gradlew -PenableCrossCompilerPlugin=true build --stacktrace ${{ steps.build_variables.outputs.REPO }}-web:installDist orca-api:dokkaJavadoc
run: ./gradlew -PenableCrossCompilerPlugin=true build --stacktrace ${{ steps.build_variables.outputs.REPO }}-web:installDist
- name: Build local slim container image for testing
uses: docker/build-push-action@v5
with:
Expand Down
58 changes: 0 additions & 58 deletions .github/workflows/docs_master.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Build
env:
ORG_GRADLE_PROJECT_version: ${{ steps.build_variables.outputs.VERSION }}
run: ./gradlew -PenableCrossCompilerPlugin=true build ${{ steps.build_variables.outputs.REPO }}-web:installDist orca-api:dokkaJavadoc
run: ./gradlew -PenableCrossCompilerPlugin=true build ${{ steps.build_variables.outputs.REPO }}-web:installDist
- name: Build slim container image
uses: docker/build-push-action@v5
with:
Expand Down
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ plugins {
id "org.jetbrains.kotlin.jvm" version "$kotlinVersion" apply false
id "org.jetbrains.kotlin.plugin.allopen" version "$kotlinVersion" apply false
id "io.gitlab.arturbosch.detekt" version "1.17.1" apply false
id "org.jetbrains.dokka" version "1.9.20" apply false
}

allprojects {
Expand Down
25 changes: 0 additions & 25 deletions gradle/dokka.gradle

This file was deleted.

3 changes: 0 additions & 3 deletions orca-api/orca-api.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ plugins {
}

apply from: "$rootDir/gradle/kotlin.gradle"
apply from: "$rootDir/gradle/dokka.gradle"
apply from: "$rootDir/gradle/spock.gradle"
apply plugin: "java-library"

Expand All @@ -41,8 +40,6 @@ dependencies {
compileOnly("org.projectlombok:lombok")
annotationProcessor("org.projectlombok:lombok")

dokkaHtmlPlugin("org.jetbrains.dokka:kotlin-as-java-plugin:1.4.32")

sampleImplementation(sourceSets.main.runtimeClasspath)
}

Expand Down

0 comments on commit 61e3762

Please sign in to comment.